1083775 - [System] status-bar label is overlapped with icons if the operator text is long in 2.0

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[sasikala]

1. Title: status-bar label is overlapped with icons if the operator text is long
2. Precondition: Insert a SIM
3. Tester's Action: 1.Pull down the notification bar
                    2.Verify the status-bar label
4. Actual Symptom (ENG.) : The status-bar label is overlapped with icons
5. Expected: The status-bar label should not be overlapped with any icons even if the operator value is long

Comment 1

[sasikala]

Dear Vance Chen,

can you please help us in assigning this issue to the correct person?

ni? to Vance Chen

Comment 3

[Rachelle Yang [:ryang][[e-mail]]]

Hi Arthur , Would you please help with the bug ?
Thank you very much !!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Flagging Guillaume as he should better know the code than me.

Comment 5

[Guillaume Marty [:gmarty]]

This bug appears on v2.0, right?
There is no status bar icon prioritisation before v2.1. In other words, there are no mechanisms to ensure that there won't be overlapping between the icon and the label.

Maybe we can fix that by using flexbox. Otherwise we need to compute the space available for the label, set its width and truncate the content when it overflows.

Comment 6

[Rachelle Yang [:ryang][[e-mail]]]

Hi Guillaume, without status bar icon prioritization, so... ...Is anything we can do on 2.0 to improve it ?
Thank you very much!

Comment 7

[Guillaume Marty [:gmarty]]

Hi Rachelle, as I said, using flexbox. You need to let the icons container grow and have the label to accomodate the remaining space. Then truncate the label if necessary.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Reopening, since bug 832281 was closed as fix in 2.1 on, and this bug applies to 2.0.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:
This is not a regression, but the only way we would work on this is if it blocks 2.0.

Comment 10

[Guillaume Marty [:gmarty]]

Still working on it. WIP is at https://github.com/gmarty/gaia/tree/Bug-1083775-status-bar-label-is-overlapped-with-icons-if-the-operator-text-is-long-in2.0

Comment 11

[Guillaume Marty [:gmarty]]

Attachment: Github PR

I tried using flexbox but the patch got too complicated. This one uses JavaScript to set the width to the label element depending on the room available.

Etienne, can you please review it?

Comment 12

[Etienne Segonzac (:etienne)]

Comment on attachment 8516071 [details] [review]
Github PR

Looks ok, but since it's a 2.0 only I really want to make sure we land the simplest and smallest patch possible.

What if we just call `resizeLabel` directly in `utility-tray-overlaywillopen` and `system-resize`. Would this cover the majority of cases? Enough to consider the blocker fixed?

Trying to find the best compromise here, and I think the suggestion above could make for a short and easily testable patch.

Comment 13

[Guillaume Marty [:gmarty]]

Comment on attachment 8516071 [details] [review]
Github PR

Etienne, as discussed offline with you, I'm going ahead with the approach to avoid the label to be resized only after the utility tray is completely opened and other issues when icons visibility changes.

I added a couple of unit tests to make sure we don't regress.

Comment 14

[Etienne Segonzac (:etienne)]

Comment on attachment 8516071 [details] [review]
Github PR

r=me with the comments on github addressed/explained

Comment 15

[Guillaume Marty [:gmarty]]

Comment on attachment 8516071 [details] [review]
Github PR

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Utility tray
[User impact] if declined: The label with the date, when the operator network is shown, is too large to fit in the status bar. It gives a bad visual experience on one of the most visible features of the OS.
[Testing completed]: The code is tested, but manual testing is needed too.
[Risk to taking this patch] (and alternatives if risky): This patch adds some new code but is unit tested so the risk is medium to low.
[String changes made]: None

Comment 16

[bhavana bajaj [:bajaj]]

(In reply to sasikala from comment #0)
> 1. Title: status-bar label is overlapped with icons if the operator text is
> long
> 2. Precondition: Insert a SIM
> 3. Tester's Action: 1.Pull down the notification bar
>                     2.Verify the status-bar label
> 4. Actual Symptom (ENG.) : The status-bar label is overlapped with icons
> 5. Expected: The status-bar label should not be overlapped with any icons
> even if the operator value is long

Can you please help verify the issue is fixed for you?

Comment 17

[bhavana bajaj [:bajaj]]

Comment on attachment 8516071 [details] [review]
Github PR

Adding verifyme for QA to help with verification given the risk here.

Comment 18

[sasikala]

(In reply to bhavana bajaj [:bajaj] from comment #16)
> (In reply to sasikala from comment #0)
> > 1. Title: status-bar label is overlapped with icons if the operator text is
> > long
> > 2. Precondition: Insert a SIM
> > 3. Tester's Action: 1.Pull down the notification bar
> >                     2.Verify the status-bar label
> > 4. Actual Symptom (ENG.) : The status-bar label is overlapped with icons
> > 5. Expected: The status-bar label should not be overlapped with any icons
> > even if the operator value is long
> 
> Can you please help verify the issue is fixed for you?

Hi Bhavana,
I have tested the issue and is working fine.
Thank you!

Comment 19

[Guillaume Marty [:gmarty]]

Landed in v2.0 in https://github.com/mozilla-b2g/gaia/commit/7c6254c7d43d607517d5cafc13f7bd4cb3715870

Comment 20

[Yeojin Chung [:YeojinC]]

Unable to verify at this location. I was unable to reproduce the original issue with the SIMs we have. The operator text never appeared on the status bar next to the date.

Device: Flame 2.0
BuildID: 20141015000206
Gaia: c6c6116ca225c2c934220ae6867e5a3256d65e00
Gecko: 24a2aa6bf1c4
Version: 32.0 (2.0) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 21

[Yeojin Chung [:YeojinC]]

(In reply to Yeojin Chung [:YeojinC] from comment #20)
> Unable to verify at this location. I was unable to reproduce the original
> issue with the SIMs we have. The operator text never appeared on the status
> bar next to the date.
> 

I was able to reproduce the original bug with Buri and when there are enough icons on the status bar. This issue is verified on Buri 2.0.

Result: The operator label is truncated when there is not enough room on the status bar.

Device: Buri 2.0
BuildID: 20141117160202
Gaia: 1ede2666f1e6c1b3fd3b282011caf0cbc59544b0
Gecko: 2bea026d4f86
Version: 32.0 (2.0) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 22

[Coler]

Verify passed, this issue can't be repro on Woodduck 2.0.
Attached: Verify_Woodduck_Notificationicon.mp4
Reproducing rate: 0/5

Woodduck 2.0 Build:
Gaia-Rev        60146ec47cd38a8be8ed22e0116902eceb9ac067
Gecko-Rev       cdfbe9866cf0b71b33454926638ce0cd8bb1fb00
Build-ID        20141117050313
Version         32.0

Comment 23

[Coler]

Attachment: Verify_Woodduck_Notificationicon.MP4