1083806 - Remote Ring should use the ‘ringtone’ audio channel, not ‘content’

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Wilfred Mathanaraj [:WDM]]

Impact: The content channel has a lower playback priority and may not be audible when another app is playing something.

Fix: Use “ringer” (commands.js)  (NB this requires the “audio-channel-ringer” permission)

Comment 1

[marta]

We use the code from find my device, and it does use that content channel:
https://github.com/mozilla-b2g/gaia/blob/master/apps/findmydevice/js/commands.js

Comment 2

[Wilfred Mathanaraj [:WDM]]

if it being not always fully audible is not an issue we dont need to make a change but given the feature set I think it makes sense to make that change so the audio is always noticeable. 

Mozilla recommendation is to make the changes to ensure its covered against any situation.

Comment 3

[marta]

Attachment: bug_1083806.patch

Comment 4

[Frederik Braun [:freddy]]

Comment on attachment 8507715 [details] [diff] [review]
bug_1083806.patch

Review of attachment 8507715 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks alright to me