1083820 - [Calendar] update MonthsDay view to use DayObserver

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

the current MonthsDay implementation is way more complex than needed. It still inherits from the old DayBased and DayChild views (have a lot of logic that is not needed anymore).

I think we should delete the old code and implement a simpler structure based on the new DayObserver.

I also think we can update the events to be simple <a> elements, which will reduce the amount of JavaScript and simplify the logic (while also improving the accessibility).

I recommend naming the new view "Agenda" and implement it in a way that is easier to change it later to display events from multiple days (like the MultiDay view). - right now that would be really hard to do and UX team showed some interest on this for the future.

Comment 1

[Miller Medeiros [:millermedeiros]]

[Tracking Requested - why for this release]: this will make new feature work simpler and remove a lot of unused code - month view still uses a lot of the logic pre v1.3 when it was basically the same layout/functionality as the day view.

Comment 2

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25413

deleted ~2000 LOC!! way easier to understand and also improved the unit tests.

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8509560 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25413

Very nice job. This is great work and I only had a few optional nits on the patch. Thanks!!

Comment 4

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/0dfc1996eb583c8b507a82bf6b8319624bba23ea