1083841 - Don't need to check 'success' when handing cfstatechange event

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Edgar Chen [:edgar]]

After bug 1000014, gecko will only send `cfstatechange` event when |success| is true, so gaia won't need to check `success` when handing the event.

[1] Please see bug 1000014 comment#0

Comment 1

[Edgar Chen [:edgar]]

I can help to provide a patch for this.

Comment 2

[Edgar Chen [:edgar]]

Attachment: [mozilla-b2g:master] PR #25243

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

I have tested it in flame-kk, it works good.
May I have your review, jaoo? Thank you.

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=21b7b9f45a18

Gaia unit test fails in `system/test/unit/call_forwarding_test.js`, I guess the test case needs to be modified as well. So cancel review request first.

Thank you.

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

Just updated the PR, try result looks good. Thank you.

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d2a6323c607e

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

LGTM. r=me

I applied the patch and ran several test (kind of smoke test around both the settings and dialer app) and it seems it works fine and nothing is broken. Rebase it, wait for a green Try and land at will.

Thanks for taking care of it.

PS. Sorry for the lag guys.

Comment 7

[Edgar Chen [:edgar]]

Thanks for the review, Jose.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/24b956e2b93d4f8d1f0a0792692dece03638d6f3