Don't need to check 'success' when handing cfstatechange event

RESOLVED FIXED in Firefox OS v2.2

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

unspecified
2.1 S7 (24Oct)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
After bug 1000014, gecko will only send `cfstatechange` event when |success| is true, so gaia won't need to check `success` when handing the event.

[1] Please see bug 1000014 comment#0
(Assignee)

Comment 1

4 years ago
I can help to provide a patch for this.
(Assignee)

Updated

4 years ago
Blocks: 1083843
(Assignee)

Comment 2

4 years ago
Created attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243
(Assignee)

Comment 3

4 years ago
Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

I have tested it in flame-kk, it works good.
May I have your review, jaoo? Thank you.
Attachment #8506611 - Flags: review?(josea.olivera)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=21b7b9f45a18

Gaia unit test fails in `system/test/unit/call_forwarding_test.js`, I guess the test case needs to be modified as well. So cancel review request first.

Thank you.
Attachment #8506611 - Flags: review?(josea.olivera)
(Assignee)

Comment 5

4 years ago
Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

Just updated the PR, try result looks good. Thank you.

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d2a6323c607e
Attachment #8506611 - Flags: review?(josea.olivera)
Comment on attachment 8506611 [details] [review]
[mozilla-b2g:master] PR #25243

LGTM. r=me

I applied the patch and ran several test (kind of smoke test around both the settings and dialer app) and it seems it works fine and nothing is broken. Rebase it, wait for a green Try and land at will.

Thanks for taking care of it.

PS. Sorry for the lag guys.
Attachment #8506611 - Flags: review?(josea.olivera) → review+
(Assignee)

Comment 7

4 years ago
Thanks for the review, Jose.
Assignee: nobody → echen
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/24b956e2b93d4f8d1f0a0792692dece03638d6f3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.2: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in before you can comment on or make changes to this bug.