Closed Bug 1083936 Opened 10 years ago Closed 10 years ago

WebGL2: Add texImage3D

Categories

(Core :: Graphics: CanvasWebGL, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

Attachments

(1 file)

Attached patch teximage3dSplinter Review
One does not just get rid of old cruft.

See thread:
https://www.khronos.org/webgl/public-mailing-list/archives/1410/msg00030.html

Minimal WIP conformance test update to give texImage3D some coverage. The present patch passes that.
https://github.com/bjacob/WebGL/tree/texImage3D-minimal-testing
Attachment #8506285 - Flags: review?(jgilbert)
No longer blocks: 1071335
Blocks: 1071335
Comment on attachment 8506285 [details] [diff] [review]
teximage3d

Review of attachment 8506285 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextTextures.cpp
@@ +277,5 @@
> +    if (dataLength && dataLength < bytesNeeded)
> +        return ErrorInvalidOperation("texImage3D: not enough data for operation (need %d, have %d)",
> +                                 bytesNeeded, dataLength);
> +
> +    WebGLTexture *tex = activeBoundTextureForTexImageTarget(texImageTarget);

Star to left.
Attachment #8506285 - Flags: review?(jgilbert) → review+
Comment on attachment 8506285 [details] [diff] [review]
teximage3d

Review of attachment 8506285 [details] [diff] [review]:
-----------------------------------------------------------------

Smaug: I'll need a DOM peer review on the WebIDL part. This is re-adding a method that was removed from the WebGL2 spec, and the removal has just been overturned in the WG today if I understand correctly; jgilbert could confirm that.
Attachment #8506285 - Flags: review?(bugs)
Confirming the above.
Attachment #8506285 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/35da3c99e658
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.