1083977 - KB Dashboard bug : Comments aren't showing up in the "needs update" column

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P3)

Description

[Joni Chan]

These articles (https://support.mozilla.org/en-US/contributors/need-changes) have "needs changes" comments that aren't showing up in the "needs update" column in the new KB dashboard. Can we get these comments to appear?

Comment 1

[Michael Cooper [:mythmon]]

The new KB dashboard doesn't have any support for needs change comments yet, but we should be able to add it. The code for this dashboard is already pretty complex. Rehan says this is 2pt.

Showing the entire comment here will probably make the UI really crazy. We can probably explore truncating the comment to make the UI less crazy.

Comment 2

[Michael Cooper [:mythmon]]

bumping to the next sprint.

Comment 3

[Michael Cooper [:mythmon]]

Pushing to next sprint.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

This column is only being used for translations, where it shows Yes if the current translation is out of date (compared to the current en-US revision).

Seems like we should put it to use in en-US by showing the needs_change_comment content, if any.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/2349

Reducing to 1pt.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/601438f5959778331120a0a8493b6d557f98cd97

Comment 7

[Michael Cooper [:mythmon]]

I just deployed this to prod.