1084107 - Jobs in the pinboard should all be the same width

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If I need to unpin a bunch of (but not all) jobs from the pinboard, it's a pain having to move the mouse around to line up with the 'x' button for each job.

If all of the jobs in the pinboard were the same width, the 'x' button for the next job would already be lined up with the cursor when I unpin a job.

Comment 1

[Jonathan French (:jfrench)]

Makes good sense to me.

Is there a character limit on the number of letters a job can have? Is it possible a user could create some really long job name?

The longest job name I've seen so far is 4 characters. Maybe we can set a width based on that assumption, reduce the padding a bit, and end up generally with the same space usage (and a consistent width).

If someone makes jobs later with 6 characters or something, I think we'd have a problem and need to address it then.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Jonathan French (:jfrench) from comment #1)
> Makes good sense to me.
> 
> Is there a character limit on the number of letters a job can have? Is it
> possible a user could create some really long job name?
> 
> The longest job name I've seen so far is 4 characters. Maybe we can set a
> width based on that assumption, reduce the padding a bit, and end up
> generally with the same space usage (and a consistent width).
> 
> If someone makes jobs later with 6 characters or something, I think we'd
> have a problem and need to address it then.

I think 3 characters makes sense for a default assumption for minimum width. IMO, anything longer than 3 can be truncated (or maybe the 4+ character jobs are rare enough that they can keep their own, wider width, whiles keeping the 1-3 character jobs a unified width?)

What do you think, Ed?

Comment 3

[Ed Morley [:emorley]]

Sounds good to me :-)

Comment 4

[Jonathan French (:jfrench)]

With respect to >3 character truncation, I had a quick look in Help in the Builds/Tests lists. There are a few very long build job names which may be of concern if they need to be pinned. For visibility, they are:

Buri/Hamachi
Helix
Inari
Nexus 4
Unagi
Wasabi
Unknown

Comment 5

[Ed Morley [:emorley]]

Perhaps lets go with:

(In reply to Wes Kocher (:KWierso) from comment #2)
> (or maybe the 4+ character jobs
> are rare enough that they can keep their own, wider width, whiles keeping
> the 1-3 character jobs a unified width?)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Jonathan French (:jfrench) from comment #4)
> With respect to >3 character truncation, I had a quick look in Help in the
> Builds/Tests lists. There are a few very long build job names which may be
> of concern if they need to be pinned. For visibility, they are:
> 
> Buri/Hamachi
> Helix
> Inari
> Nexus 4
> Unagi
> Wasabi
> Unknown

Those currently show up as only 'B' (and 'Be') in the pinboard, so I don't know why that'd be different in the future.

Comment 7

[Jonathan French (:jfrench)]

Ah, cool. Sorry I didn't realize that those builds get compressed. I'll make the change for all as 3-characters and see how that works locally.

Comment 8

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#243

Please see the above PR for review and status.

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/df4fe0da2919e297cc23aff847ecf513bf6bef76
Bug 1084107 - Make consistent width pinboard jobs for faster closure

https://github.com/mozilla/treeherder-ui/commit/aa824f2aa4330b55565aed517705674a54874b33
Merge pull request #243 from tojonmz/consistent-pinned-jobs

Bug 1084107 - Make consistent width pinboard jobs for faster closure

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8508734 [details] [review]
treeherder-ui-PR#243

Looks great, thank you!

Comment 11

[William Lachance (:wlach)]

Merged.

Comment 12

[Jonathan French (:jfrench)]

Verified fixed and working correctly on dev/stage in Firefox and Chrome.

Comment 13

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9a77494b1ee11e91bd2cc95d6047fb04ca4c0646
Bug 1084107 - Make consistent width pinboard jobs for faster closure

https://github.com/mozilla/treeherder/commit/55cf400b4b8bba30f3bf174915dc342ae0fcea49
Merge pull request #243 from tojonmz/consistent-pinned-jobs

Bug 1084107 - Make consistent width pinboard jobs for faster closure