Closed
Bug 1084140
Opened 10 years ago
Closed 10 years ago
content/media/gtest/TestWebMBuffered.cpp:29:37: error: 'ArrayLength' was not declared in this scope (non-SPS)
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file)
947 bytes,
patch
|
kinetik
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
On platforms lacking SPS profiler (Linux/PPC, BSDs, Solaris) non-unified build is broken due to header bootlegging. BasicTests for empty .webm file still uses data array. content/media/gtest/TestWebMBuffered.cpp:29:22: error: use of undeclared identifier 'ArrayLength' parser.Append(buf, ArrayLength(buf), mapping, dummy); ^ 1 error generated. In file included from content/media/gtest/TestWebMBuffered.cpp:8: In file included from ../../../dist/include/WebMBufferedParser.h:11: In file included from ../../../dist/include/mozilla/ReentrantMonitor.h:13: In file included from ../../../dist/include/GeckoProfiler.h:201: In file included from ../../../dist/include/GeckoProfilerImpl.h:17: ../../../dist/include/PseudoStack.h:9:2: error: "bootleg check" #error "bootleg test" ^ 1 error generated. Only release channels are affected with implicit --disable-unified-compilation. http://buildbot.rhaalovely.net/builders/mozilla-aurora-freebsd-amd64/builds/440/steps/build/logs/stdio
Attachment #8506534 -
Flags: review?(kinetik)
Updated•10 years ago
|
Attachment #8506534 -
Flags: review?(kinetik) → review+
Keywords: checkin-needed
Comment on attachment 8506534 [details] [diff] [review] put back #include Approval Request Comment [Feature/regressing bug #]: bug 1073998 regression [User impact if declined]: broken build on Tier3 platforms on Aurora/Beta/Release [Describe test coverage new/current, TBPL]: m-i soon [Risks and why]: Low, only needs to pass build in order to filter typos. [String/UUID change made/needed]: None
Attachment #8506534 -
Flags: approval-mozilla-aurora?
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/823bfffdf57a
Assignee: nobody → jbeich
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/823bfffdf57a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8506534 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•