Closed Bug 1084200 Opened 10 years ago Closed 9 years ago

Mozilla.org Hello /whatsnew, /firstrun web elements development

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ckprice, Assigned: agibson)

References

Details

(Whiteboard: [kb=1642350])

      No description provided.
Removing as a blocker for GA 35. Still a possibility for GA 36.
Due Date: 2015-02-02
No longer blocks: 1084075
Assignee: nobody → agibson
Summary: Mozilla.org Hello /whatsnew web elements development → Mozilla.org Hello /whatsnew, /firstrun web elements development
Whiteboard: [kb=1642350]
:agibson -

Let me know if you have all the assets you need to get started on development.

Design bug 1099468
UX bug 1084199
Copy bug 1099465
Analytics bug 1114670 comment 9
Engineering tracker bug 1113400
First draft of Hello whatsnew & firstrun tours are up on demo2. Please make sure to test in the latest Firefox Nightly:

https://www-demo2.allizom.org/en-US/firefox/36.0/firstrun/
https://www-demo2.allizom.org/en-US/firefox/36.0/whatsnew/?oldversion=35.0

As usual please make sure to have whitelisted `https://www-demo2.allizom.org` in `browser.uitour.testingOrigins` for the tour to work.

Please note the post-tour page is not currently implemented, but that may follow later today :)
:MattN, :jaws

Is it okay to register multiple, different pageID's on the same page?

The current /whatsnew and /firstrun framework registers a pageID[0].

We want to add additional functionality which registers a pageID when the Hello panel is opened (ref 1115227).

Do you foresee any issues here?

[0] https://github.com/mozilla/bedrock/blob/c3f839982314346325bbfcf84dd5753a3628dc3f/media/js/firefox/australis/browser-tour.js#L116
Flags: needinfo?(jaws)
Flags: needinfo?(MattN+bmo)
I think the one at [0] isn't going to be used for your analytics, correct? I suspect it also won't start with "hello-tour_OpenPanel_" so it won't interfere.

The last page ID registered with the prefix "hello-tour_OpenPanel_" in the last hour is what will be used for the analytics URL parameter.
Flags: needinfo?(jaws)
Flags: needinfo?(MattN+bmo)
I've pushed(In reply to Matthew N. [:MattN] from comment #7)
> I think the one at [0] isn't going to be used for your analytics, correct? I
> suspect it also won't start with "hello-tour_OpenPanel_" so it won't
> interfere.
> 
> The last page ID registered with the prefix "hello-tour_OpenPanel_" in the
> last hour is what will be used for the analytics URL parameter.

Thanks Matt & Cory - registering a second page ID when the Hello panel opens seems to work fine. I've pushed this change to demo2, and I can see the query param being appended to the Hello FTE from both tours as expected.
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/259f1d2bca83b4244d68c7d102112c9124960d36
[fix bug 1099471 1084200] Implement Firefox Hello tours GA 36

https://github.com/mozilla/bedrock/commit/98a0fb1dc7fd0322cba355ee0e5c01634fd5bd4b
Merge pull request #2749 from mozilla/hello-tours

[fix bug 1099471 1084200] Implement Firefox Hello tours GA 36
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.