1084203 - The bookmark manager is empty

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33a1 ID:20141015003005 c-c:06b9b65bc279 m-c:62f0b771583c

Reproducible: Every time

Steps to reproduce:
1a. Hit Ctrl+B
or
1b. Bookmarks → Manage bookmarks

Actual results:
The bookmark manager opens, but it is empty.

Expected results:
My bookmarks should be visible in the bookmark manager.

Additional info:
My bookmarks are visible in the Bookmark menu, and bookmark folders still correctly produce submenus (and sub-submenus, where applicable).

I'm not sure if this bug is in the SeaMonkey bookmarks frontend or in the Toolkit Places backend, hence the places@toolkit Cc. Maybe both (was there a recent change in the backend which broke the frontend?)

N.B. The SeaMonkey "Bookmarks & History" module seems unowned, so I'm guessing who may act as owner & peers for its bugs. Please redirect if I missed.

This bug is fairly recent. I don't think I saw it in SeaMonkey 2.32a1 (but if someone else sees it in 2.32a2, please update the flags accordingly).

Comment 1

[Stefan [:stefanh]]

This is what I get in the console when launching the BM:
Error: TypeError: bs.setFolderReadonly is not a function
Source File: resource:///modules/PlacesUIUtils.jsm
Line: 1077

Error: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: Component returned failure code: 0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS) [nsINavBookmarksService.runInBatchMode]
Source File: resource:///modules/PlacesUIUtils.jsm
Line: 1124

Comment 2

[Marco Bonardo [:mak]]

this is likely a Seamonkey regressions due to toolkit changes in bug 1068671.

Comment 3

[Stefan [:stefanh]]

Looks like this is caused by http://hg.mozilla.org/mozilla-central/rev/b30d47d94a85

Comment 4

[Stefan [:stefanh]]

(mid-aired)

Comment 7

[Tony Mechelynck [:tonymec]]

Duplicate bug 1083480 is for platform "Other / Mac OS X" => setting this bug to All/All.

Comment 8

[Stefan [:stefanh]]

Attachment: Mostly C&P

This is a straight port of Mano’s work in bug 1068671, it also includes the fix in bug 1083376. It doesn’t work, though (It could be because it's late at night for me and I've just done c&p). I don't know if I'll be able to pick this up again, but the patch can probably be used as a as starting point for someone else.

Comment 9

[[e-mail]]

Comment on attachment 8507250 [details] [diff] [review]
Mostly C&P

Actually this patch seems to work, but you might need the patches in bug 1087942 too.

Comment 11

[Stefan [:stefanh]]

Comment on attachment 8507250 [details] [diff] [review]
Mostly C&P

I'm not able to build (unrelated to this) atm and I'm leaving for vacation (1 week) tomorrow. But there's no reason that it shouldn't work on mac if it works on win or linux.

Comment 12

[Hartmut Figge]

'Mostly C&P' works on x86_64, but only with the additional patches mentioned in Comment 9.

Comment 13

[Stefan [:stefanh]]

(In reply to Hartmut Figge from comment #12)
> 'Mostly C&P' works on x86_64, but only with the additional patches mentioned
> in Comment 9.

Thanks Hartmut, I feel much better now :-)

Comment 14

[[e-mail]]

Comment on attachment 8507250 [details] [diff] [review]
Mostly C&P

>-    case "placesCmd_new:folder":
>+    case "placesCmd_new:folder":                         
Bogus whitespace change. r=me with that fixed.

>+    return parentNode != null &&
Nit: explicit != null is probably unnecessary.

>+    let obs = Object.freeze({
Nit: freezing of this object is probably unnecessary.

Comment 15

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/072eb34fcd1f

>>-    case "placesCmd_new:folder":
>>+    case "placesCmd_new:folder":                         
> Bogus whitespace change. r=me with that fixed.

>>+    return parentNode != null &&
> Nit: explicit != null is probably unnecessary.

>>+    let obs = Object.freeze({
> Nit: freezing of this object is probably unnecessary.
I fixed the above issues on checkin.

Comment 16

[Hartmut Figge]

Verified fixed with new build on Linux x86_64.

Comment 17

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33a1 ID:20141026003001 c-c:4b11354bfcf1 m-c:441055ff60e5