1084289 - The close button is not visible on certain locales and browser window sizes in the notification bar

Status: NEW

(Toolkit :: PopupNotifications and Notification Bars, defect)

Description

[Teodor Druta]

Attachment: Screenshot from 2014-10-09 14:35:58.png

Steps to reproduce:
1. Open Firefox [ta] locale
2. Open https://www.itisatrap.org/firefox/its-an-attack.html
3. Click on "Ignore this warning" or "இந்த எச்சரிக்கையை தவிர்"
4. Resize browser window
5. Notice the clipping close button in the notification area

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Teodor, would it be possible for you to check by which dimensions the close button is clipped off?

Comment 2

[Teodor Druta]

It depends on the locale and I think it also could depend on the system font family and font size.

For example on Ubuntu 14.04 with unity:
For the [ta] locale is 672px in width and lower.
For the [bn] locale is 409px in width and lower.

A list of the affected locales can be found in the report:
http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-24&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testNotificationBar
with the Error Message: "The Close button has not been found".

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

CC'ing Axel and Francesco given that this is related to localizations.

Comment 4

[Andrei Eftimie]

(In reply to Henrik Skupin (:whimboo) from comment #3)
> CC'ing Axel and Francesco given that this is related to localizations.

I would say it's a UI issue. The UI should properly accommodate all content, and should not break if the content comes in different flavours.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Well, there are multiple ways to get this fixed. Locales could define a minimum width of the window, so that this will not happen. If that is not appropriate the XUL code would have to be changed so we can make sure the close button is always visible while the text may become unreadable or could overlay other areas. Given that this is happening for some locales with longer strings, those could even be shortened. But all that is not our call and warrants feedback from developers and localizers. May point here is that everyone should be informed about this situation.

Comment 6

[Axel Hecht [:Pike]]

Given that the main window can be made as small as the user wants, the notification code should be as flexible as possible, and make sure that the most important action is available as long as possible.

I suspect that one could create a standalone xul testcase that demonstrates how the notification code handles vertical space stress?

On the l10n side, I suspect that within the given context, translations can pick shorter phrases without loosing too much meaning. I wonder if we can get help in providing good bug reports. Screen shots for the worst offenders would be helpful, for example.

Comment 7

[Teodor Druta]

What do you mean by "worst offenders", is it by window size, platform, font related, so I can provide more screenshots with other locales/platforms.

I will prepare the simplified testcase next.

Comment 8

[Teodor Druta]

(In reply to Axel Hecht [:Pike] from comment #6) 
> I suspect that one could create a standalone xul testcase that demonstrates
> how the notification code handles vertical space stress?

Axel, I think this link: https://www.itisatrap.org/firefox/its-an-attack.html shows the problem, one could just open the link, click on the ignore warning anchor and resize the window to see how the close button is clipping. Do you require a simplified standalone mozmill test ?