Closed Bug 1084459 Opened 7 years ago Closed 7 years ago

Enable web-platform-tests on Windows

Categories

(Testing :: web-platform-tests, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgraham, Assigned: jgraham)

Details

Attachments

(1 file, 1 obsolete file)

I will do a final cedar run to check that these are still stable after the last update, but based on previous experience they should be as stable as Linux.
Attachment #8507034 - Flags: review?(jlund)
Assignee: nobody → james
Status: NEW → ASSIGNED
Comment on attachment 8507034 [details] [diff] [review]
Enable web-platform-tests on Windows

Review of attachment 8507034 [details] [diff] [review]:
-----------------------------------------------------------------

looks good but due to new gecko_version for trunk based branches, we need to change this a bit. See in line comments.

::: mozilla-tests/config.py
@@ +1827,5 @@
>                      BRANCHES[name]['platforms'][platform][slave_platform]['opt_unittest_suites'] += MARIONETTE[:]
>                      BRANCHES[name]['platforms'][platform][slave_platform]['debug_unittest_suites'] += MARIONETTE[:]
>  
>  # Enable wpt on opt linux64 for gecko >= 34
>  for platform in PLATFORMS.keys():

trunk is now 36 so landing this will add win32 to m-c and m-a immediately.

I'd imagine we would like this to ride the trains so we should duplicate this block but change the following:

@@ +1828,5 @@
>                      BRANCHES[name]['platforms'][platform][slave_platform]['debug_unittest_suites'] += MARIONETTE[:]
>  
>  # Enable wpt on opt linux64 for gecko >= 34
>  for platform in PLATFORMS.keys():
> +    if platform not in ['linux', 'linux64', 'win32']:

s/'linux', 'linux64'/'win32'

@@ +1833,2 @@
>          continue
>      for name, branch in items_at_least(BRANCHES, 'gecko_version', 35):

s/35/36
Attachment #8507034 - Flags: review?(jlund) → review-
Attachment #8510182 - Flags: review?(jlund)
Attachment #8507034 - Attachment is obsolete: true
Comment on attachment 8510182 [details] [diff] [review]
Enable web-platform-tests on Windows

Review of attachment 8510182 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ +1780,5 @@
>                  if slave_platform in BRANCHES[name]['platforms'][platform]:
>                      BRANCHES[name]['platforms'][platform][slave_platform]['opt_unittest_suites'] += MARIONETTE[:]
>                      BRANCHES[name]['platforms'][platform][slave_platform]['debug_unittest_suites'] += MARIONETTE[:]
>  
> +# Enable wpt on linux[64] opt for gecko >= 35

thanks for the fix there.

@@ +1792,5 @@
>                      BRANCHES[name]['platforms'][platform][slave_platform]['opt_unittest_suites'] += WEB_PLATFORM_TESTS_CHUNKED[:] + WEB_PLATFORM_REFTESTS[:]
>  
> +# Enable wpt on windows opt for gecko >= 36
> +for platform in PLATFORMS.keys():
> +    if platform not in ['win32', 'win64']:

oh neat, win64 too
Attachment #8510182 - Flags: review?(jlund) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.