Closed
Bug 1084483
Opened 8 years ago
Closed 8 years ago
Disable/remove tracking of peak link.exe memory
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: jmaher)
References
Details
Attachments
(3 files)
5.79 KB,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
1.10 KB,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
12.01 KB,
patch
|
coop
:
review+
|
Details | Diff | Splinter Review |
Tracking of the peak memory usage of link.exe was added in bug 710840. Now that we are using a 64-bit compiler/linker toolchain with MSVC2013, this number is not longer interesting, and I suggest that we disable this test. We may not want to totally remove the code for 6 weeks in case a regression forces us to revert back to MSVC2010.
Assignee | ||
Comment 1•8 years ago
|
||
I think enough time has elapsed to consider removing this. We are still uploading the link data: http://graphs.mozilla.org/graph.html#tests=[[205,1,8]]&sel=1398101349059,1429637349059&displayrange=365&datatype=geo
Flags: needinfo?(benjamin)
Reporter | ||
Comment 2•8 years ago
|
||
What info do you need from me?
Flags: needinfo?(benjamin) → needinfo?(jmaher)
Assignee | ||
Comment 3•8 years ago
|
||
yeah, that wasn't clear, do you have any objections to me removing this?
Flags: needinfo?(jmaher) → needinfo?(benjamin)
Reporter | ||
Comment 4•8 years ago
|
||
No, I requested it in the first place ;-)
Flags: needinfo?(benjamin)
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8597994 -
Flags: review?(coop)
Updated•8 years ago
|
Attachment #8597994 -
Flags: review?(coop) → review+
Updated•8 years ago
|
Attachment #8597992 -
Flags: review?(coop) → review+
Comment 7•8 years ago
|
||
Can _count_vsize also go away then? http://mxr.mozilla.org/build/source/mozharness/mozharness/mozilla/building/buildbase.py#1118
Assignee | ||
Comment 8•8 years ago
|
||
thanks for finding the mozharness bits- I have removed all references to vsize :)
Attachment #8598085 -
Flags: review?(coop)
Updated•8 years ago
|
Attachment #8598085 -
Flags: review?(coop) → review+
Assignee | ||
Comment 9•8 years ago
|
||
I assume there will need to be an order of operations here. Some concerns: 1) landing the buildbot* changes will cause mozharness to fail 2) landing mozharness changes need to be on ALL branches (b2g*, esr*, m-r, etc.) 3) I assume once mozharness changes are in then we can land the buildbot changes? I could use some guidance/confirmation here.
Flags: needinfo?(coop)
Comment 10•8 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #9) > I assume there will need to be an order of operations here. Some concerns: > 1) landing the buildbot* changes will cause mozharness to fail > 2) landing mozharness changes need to be on ALL branches (b2g*, esr*, m-r, > etc.) > 3) I assume once mozharness changes are in then we can land the buildbot > changes? The buildbot-config and mozharness implementations are orthogonal, so order-of-landing shouldn't matter. The default in both cases is to pref the vsize collection off, so we should be fine.
Flags: needinfo?(coop)
Assignee | ||
Comment 11•8 years ago
|
||
buildbotcustom changes: https://hg.mozilla.org/build/buildbotcustom/rev/c8d37797bbd8 buildbot-config changes: https://hg.mozilla.org/build/buildbot-configs/rev/67ed57cae441 mozharness changes: https://hg.mozilla.org/build/mozharness/rev/b8e46610ae63 I will let the natural courses of reconfigs and mozharness updates on branches take effect.
Comment 12•8 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/67ed57cae441
Comment 13•8 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/c8d37797bbd8
Comment 14•8 years ago
|
||
mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/ca580fcfa627
Assignee | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 15•8 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/67ed57cae441
Comment 16•8 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/c8d37797bbd8
Comment 17•8 years ago
|
||
mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/4d260376921f
Updated•5 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•