Update Android SDK and build tools to 21

RESOLVED FIXED

Status

task
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: rnewman, Assigned: wesj)

Tracking

other
All
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox34 wontfix, firefox35+ fixed, firefox36 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

5 years ago
Just like Bug 1042829.

Build tools/platform tools 21 and SDK 23.0.5 are out. It's upgrade time!

I'm testing a build locally now.
Reporter

Updated

5 years ago
Depends on: 1084516
Reporter

Updated

5 years ago
Depends on: 1084517
Reporter

Updated

5 years ago
Depends on: 1084521
Reporter

Updated

5 years ago
Depends on: 1084522
Reporter

Updated

5 years ago
Depends on: 1084523
Reporter

Updated

5 years ago
No longer depends on: 1084523
Reporter

Updated

5 years ago
No longer depends on: 1084517
Reporter

Updated

5 years ago
Blocks: 1019726
Reporter

Comment 1

5 years ago
Builds work, so this is ready to go.
rnewman: With the changes to tooltool, :wesj was able to do this himself for SDK 20 over in bug 1042829. Do you need releng assistance on this?
Flags: needinfo?(rnewman)
Reporter

Comment 3

5 years ago
I think that basically means "over to wesj to upload current tools to tooltool" :)

AFAIK I don't have the right account bits set in LDAP, and if I can avoid it I'd like to not spend an afternoon figuring out tooltool.py.


"Current" means SDK 23.0.5, platform-tools 21, build-tools 21.1.

(There are also support library and Play services updates available, fwiw.)

I can take care of altering the in-tree stuff once things are available.

Wes, can you help with this?
Flags: needinfo?(rnewman) → needinfo?(wjohnston)
Assignee

Comment 4

5 years ago
Yeah. Uploading something now....
Assignee: nobody → wjohnston
Flags: needinfo?(wjohnston)
Assignee

Comment 5

5 years ago
Posted patch Patch (obsolete) — Splinter Review
This should work (the sdk does locally). Try is down right now.
Attachment #8520243 - Flags: review?(coop)
Comment on attachment 8520243 [details] [diff] [review]
Patch

Review of attachment 8520243 [details] [diff] [review]:
-----------------------------------------------------------------

If the digest is changing, I'm willing to bet the corresponding "size" should be changing too in the manifests.
Attachment #8520243 - Flags: review?(coop) → review-
Assignee

Updated

5 years ago
Blocks: 1097337
Assignee

Comment 7

5 years ago
Posted patch PatchSplinter Review
Hope I can use the size my desktop gives me:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=febe2fed01c2
Attachment #8520243 - Attachment is obsolete: true
Attachment #8522482 - Flags: review?(coop)
Comment on attachment 8522482 [details] [diff] [review]
Patch

Review of attachment 8522482 [details] [diff] [review]:
-----------------------------------------------------------------

mobile/android/config/tooltool-manifests/android-armv6/releng.manifest still needs to have the size updated.

Conditional r+ with that fixed.
Attachment #8522482 - Flags: review?(coop) → review+
Reporter

Comment 10

5 years ago
ni on Wes to consider this for uplift if it works on m-c.
Status: NEW → ASSIGNED
Flags: needinfo?(wjohnston)
https://hg.mozilla.org/mozilla-central/rev/05323e55599d
https://hg.mozilla.org/mozilla-central/rev/5fb37ccaf137
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Reporter

Comment 13

5 years ago
Ping, Wes?
Assignee

Comment 14

5 years ago
Comment on attachment 8522482 [details] [diff] [review]
Patch

I think this fixed the overscroll glow on Android L (haven't confirmed that, but seems likely this was what fixed it to me), so I'm going to nom it for uplift to Beta.

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: No overscroll glow on L. Can't use any 21 features
[Describe test coverage new/current, TBPL]:
[Risks and why]: New SDK could introduce new edge case bugs. But I'd say its low risk. Haven't seen anything on central yet.
[String/UUID change made/needed]: None.
Flags: needinfo?(wjohnston)
Attachment #8522482 - Flags: approval-mozilla-beta?
Attachment #8522482 - Flags: approval-mozilla-aurora?
Reporter

Comment 15

5 years ago
Note that this change very likely results in an APK that won't install on Gingerbread devices, so I'd test really carefully before you uplift. See Bug 1100361.

jlund is in the process of finishing up splitapk work for builders and the updater service, but that won't yet affect Google Play, and we need to get those ducks in a row before this hits beta or release.
Version: unspecified → other
Reporter

Comment 16

5 years ago
Just to avoid grubbing around in that bug: the SDK bump carries with it a much fatter Play Services library, which puts us over some internal limits in Gingerbread. Those limits were bumped from 5MB to 8MB in a later release.
Comment on attachment 8522482 [details] [diff] [review]
Patch

It's too late to take this change in 34. We can consider it for 35.
Attachment #8522482 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #8522482 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee

Updated

4 years ago
Blocks: 1165422
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.