1084498 - Update Android SDK and build tools to 21

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Richard Newman [:rnewman]]

Just like Bug 1042829.

Build tools/platform tools 21 and SDK 23.0.5 are out. It's upgrade time!

I'm testing a build locally now.

Comment 1

[Richard Newman [:rnewman]]

Builds work, so this is ready to go.

Comment 2

[Chris Cooper [:coop] (he/him)]

rnewman: With the changes to tooltool, :wesj was able to do this himself for SDK 20 over in bug 1042829. Do you need releng assistance on this?

Comment 3

[Richard Newman [:rnewman]]

I think that basically means "over to wesj to upload current tools to tooltool" :)

AFAIK I don't have the right account bits set in LDAP, and if I can avoid it I'd like to not spend an afternoon figuring out tooltool.py.


"Current" means SDK 23.0.5, platform-tools 21, build-tools 21.1.

(There are also support library and Play services updates available, fwiw.)

I can take care of altering the in-tree stuff once things are available.

Wes, can you help with this?

Comment 4

[Wesley Johnston (:wesj)]

Yeah. Uploading something now....

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch

This should work (the sdk does locally). Try is down right now.

Comment 6

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8520243 [details] [diff] [review]
Patch

Review of attachment 8520243 [details] [diff] [review]:
-----------------------------------------------------------------

If the digest is changing, I'm willing to bet the corresponding "size" should be changing too in the manifests.

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch

Hope I can use the size my desktop gives me:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=febe2fed01c2

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8522482 [details] [diff] [review]
Patch

Review of attachment 8522482 [details] [diff] [review]:
-----------------------------------------------------------------

mobile/android/config/tooltool-manifests/android-armv6/releng.manifest still needs to have the size updated.

Conditional r+ with that fixed.

Comment 9

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/05323e55599d

Comment 10

[Richard Newman [:rnewman]]

ni on Wes to consider this for uplift if it works on m-c.

Comment 11

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/5fb37ccaf137

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/05323e55599d
https://hg.mozilla.org/mozilla-central/rev/5fb37ccaf137

Comment 13

[Richard Newman [:rnewman]]

Ping, Wes?

Comment 14

[Wesley Johnston (:wesj)]

Comment on attachment 8522482 [details] [diff] [review]
Patch

I think this fixed the overscroll glow on Android L (haven't confirmed that, but seems likely this was what fixed it to me), so I'm going to nom it for uplift to Beta.

Approval Request Comment
[Feature/regressing bug #]: None
[User impact if declined]: No overscroll glow on L. Can't use any 21 features
[Describe test coverage new/current, TBPL]:
[Risks and why]: New SDK could introduce new edge case bugs. But I'd say its low risk. Haven't seen anything on central yet.
[String/UUID change made/needed]: None.

Comment 15

[Richard Newman [:rnewman]]

Note that this change very likely results in an APK that won't install on Gingerbread devices, so I'd test really carefully before you uplift. See Bug 1100361.

jlund is in the process of finishing up splitapk work for builders and the updater service, but that won't yet affect Google Play, and we need to get those ducks in a row before this hits beta or release.

Comment 16

[Richard Newman [:rnewman]]

Just to avoid grubbing around in that bug: the SDK bump carries with it a much fatter Play Services library, which puts us over some internal limits in Gingerbread. Those limits were bumped from 5MB to 8MB in a later release.

Comment 17

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8522482 [details] [diff] [review]
Patch

It's too late to take this change in 34. We can consider it for 35.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/110d3d7a1335