1084505 - Fix explicit permission lookup for trusted hosted apps

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Zoran Jovanovic]

Settings application doesn't show permissions of
trusted hosted apps in 'App permissions' section, due to
missing lookup in PermissionsTable.

Comment 1

[Zoran Jovanovic]

Attachment: Bug_1084505-Fix-explicit-permission-lookup-for-trusted-hosted-ap.patch

Comment 2

[Francis Lee [:frlee]]

hi Bhavana,

since this patch has been review+, i would like to request approval for uplifting to 2.1

Comment 3

[Francis Lee [:frlee]]

hi Bhavana,

any risk for this one?

Comment 4

[bhavana bajaj [:bajaj]]

Spoke offline with fabrice, these are fine to land. Zoran attach the tryserver results once you are able to land these on your side. Hoping that is green you can add "checkin-needed" for this to land on central by sheriff's. Once that's done you'll have to seek approval to land it on 2.1

Comment 5

[Keven Kuo [:kkuo]]

Hi! Bhavana,

This case is not updated for two months.
I wonder this is still a 2.1 blocker, or not?

--
Keven

Comment 6

[bhavana bajaj [:bajaj]]

(In reply to Keven Kuo [:kkuo] from comment #5)
> Hi! Bhavana,
> 
> This case is not updated for two months.
> I wonder this is still a 2.1 blocker, or not?
> 
> --
> Keven

Thanks Keven, I guess we can remove it form the blocking list at this point. So cleaning the flag up.

Comment 7

[Beatriz Rodríguez [:brg]]

There is a patch for this issue that got r+, can it be landed in master to fix the reported bug?

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Beatriz Rodríguez [:brg] from comment #7)
> There is a patch for this issue that got r+, can it be landed in master to
> fix the reported bug?

it can be, but i'll leave it to fabrice on that piece if he think's we need to it here.

Comment 9

[[:fabrice] Fabrice Desré]

Yep, let's take it.

Comment 10

[Carsten Book [:Tomcat]]

(In reply to Fabrice Desré [:fabrice] from comment #9)
> Yep, let's take it.

Fabrice: i guess this need a try run or ?

Comment 11

[[:fabrice] Fabrice Desré]

(In reply to Carsten Book [:Tomcat] from comment #10)
> (In reply to Fabrice Desré [:fabrice] from comment #9)
> > Yep, let's take it.
> 
> Fabrice: i guess this need a try run or ?

Right, https://treeherder.mozilla.org/#/jobs?repo=try&revision=526f3ba2822c

Comment 12

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/22e21fde8e18

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/22e21fde8e18