Closed Bug 1084505 Opened 8 years ago Closed 7 years ago

Fix explicit permission lookup for trusted hosted apps

Categories

(Core Graveyard :: DOM: Apps, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: zoran.jovanovic, Assigned: zoran.jovanovic)

Details

(Whiteboard: [Tako_Blocker])

Attachments

(1 file)

Settings application doesn't show permissions of
trusted hosted apps in 'App permissions' section, due to
missing lookup in PermissionsTable.
Attachment #8507081 - Flags: review?(jonas)
Attachment #8507081 - Flags: review?(fabrice)
Attachment #8507081 - Flags: review+
Whiteboard: [Tako_Blocker]
hi Bhavana,

since this patch has been review+, i would like to request approval for uplifting to 2.1
Flags: needinfo?(bbajaj)
hi Bhavana,

any risk for this one?
Spoke offline with fabrice, these are fine to land. Zoran attach the tryserver results once you are able to land these on your side. Hoping that is green you can add "checkin-needed" for this to land on central by sheriff's. Once that's done you'll have to seek approval to land it on 2.1
blocking-b2g: --- → 2.1+
Flags: needinfo?(bbajaj)
Assignee: nobody → zoran.jovanovic
Hi! Bhavana,

This case is not updated for two months.
I wonder this is still a 2.1 blocker, or not?

--
Keven
Flags: needinfo?(bbajaj)
(In reply to Keven Kuo [:kkuo] from comment #5)
> Hi! Bhavana,
> 
> This case is not updated for two months.
> I wonder this is still a 2.1 blocker, or not?
> 
> --
> Keven

Thanks Keven, I guess we can remove it form the blocking list at this point. So cleaning the flag up.
blocking-b2g: 2.1+ → ---
Flags: needinfo?(bbajaj)
There is a patch for this issue that got r+, can it be landed in master to fix the reported bug?
Flags: needinfo?(bbajaj)
(In reply to Beatriz Rodríguez [:brg] from comment #7)
> There is a patch for this issue that got r+, can it be landed in master to
> fix the reported bug?

it can be, but i'll leave it to fabrice on that piece if he think's we need to it here.
Flags: needinfo?(bbajaj) → needinfo?(fabrice)
Yep, let's take it.
Flags: needinfo?(fabrice)
Keywords: checkin-needed
(In reply to Fabrice Desré [:fabrice] from comment #9)
> Yep, let's take it.

Fabrice: i guess this need a try run or ?
Flags: needinfo?(fabrice)
Keywords: checkin-needed
(In reply to Carsten Book [:Tomcat] from comment #10)
> (In reply to Fabrice Desré [:fabrice] from comment #9)
> > Yep, let's take it.
> 
> Fabrice: i guess this need a try run or ?

Right, https://treeherder.mozilla.org/#/jobs?repo=try&revision=526f3ba2822c
Flags: needinfo?(fabrice)
https://hg.mozilla.org/mozilla-central/rev/22e21fde8e18
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.