1084521 - did you mean to use @+id instead of @+android:id?

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Firefox Accounts, defect)

Description

[Richard Newman [:rnewman]]

21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:37: note: did you mean to use @+id instead of @+android:id?
21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:48: note: did you mean to use @+id instead of @+android:id?
21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:90: note: did you mean to use @+id instead of @+android:id?
21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:101: note: did you mean to use @+id instead of @+android:id?

Comment 1

[Richard Newman [:rnewman]]

Probably causes this, too:

21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:37: error: creating resource for external package android: id/account_server_title.
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:37: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/account_server_title').
21:28.09
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:48: error: creating resource for external package android: id/account_server_summary.
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:48: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/account_server_summary').
21:28.09
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:90: error: creating resource for external package android: id/sync_server_title.
21:28.10 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:90: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/sync_server_title').
21:28.10
21:28.10 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:101: error: creating resource for external package android: id/sync_server_summary.
21:28.10 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:101: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/sync_server_summary').

Comment 2

[Richard Newman [:rnewman]]

Attachment: Use +id not +android:id. v1

This looks like an over-zealous s//.

Uplift needed.

Comment 3

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/pull/503

Comment 4

[Lucas Rocha (:lucasr)]

Comment on attachment 8507228 [details] [diff] [review]
Use +id not +android:id. v1

Review of attachment 8507228 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/eb04720f2290

Comment 6

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/commit/0e4ebcf489f1bbd85eea038a0218006c5c76421a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eb04720f2290

Comment 8

[Nathan Toone [:toonetown]]

This patch applies cleanly to (at least) the beta branch (firefox-34) and fixes the same issue that occurs when building against that branch as well.  I haven't tested if the patch applies cleanly to aurora (firefox-35), but I would assume that it does.

Comment 9

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8507228 [details] [diff] [review]
Use +id not +android:id. v1

Approval Request Comment
[Feature/regressing bug #]: no idea.
[User impact if declined]: none; this is build only.
[Describe test coverage new/current, TBPL]: none needed, this is build only.
[Risks and why]: none.
[String/UUID change made/needed]: none.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fba3e828d330
https://hg.mozilla.org/releases/mozilla-beta/rev/81b50459db25