did you mean to use @+id instead of @+android:id?

RESOLVED FIXED in Firefox 34

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
Firefox 36
All
Android

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:37: note: did you mean to use @+id instead of @+android:id?
21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:48: note: did you mean to use @+id instead of @+android:id?
21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:90: note: did you mean to use @+id instead of @+android:id?
21:27.88 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:101: note: did you mean to use @+id instead of @+android:id?
(Assignee)

Comment 1

4 years ago
Probably causes this, too:

21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:37: error: creating resource for external package android: id/account_server_title.
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:37: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/account_server_title').
21:28.09
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:48: error: creating resource for external package android: id/account_server_summary.
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:48: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/account_server_summary').
21:28.09
21:28.09 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:90: error: creating resource for external package android: id/sync_server_title.
21:28.10 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:90: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/sync_server_title').
21:28.10
21:28.10 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:101: error: creating resource for external package android: id/sync_server_summary.
21:28.10 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/fxaccount_custom_server_view.xml:101: error: Error: No resource found that matches the given name (at 'id' with value '@+android:id/sync_server_summary').
(Assignee)

Comment 2

4 years ago
Created attachment 8507228 [details] [diff] [review]
Use +id not +android:id. v1

This looks like an over-zealous s//.

Uplift needed.
Attachment #8507228 - Flags: review?(nalexander)
(Assignee)

Updated

4 years ago
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment on attachment 8507228 [details] [diff] [review]
Use +id not +android:id. v1

Review of attachment 8507228 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.
Attachment #8507228 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/eb04720f2290
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
This patch applies cleanly to (at least) the beta branch (firefox-34) and fixes the same issue that occurs when building against that branch as well.  I haven't tested if the patch applies cleanly to aurora (firefox-35), but I would assume that it does.
Comment on attachment 8507228 [details] [diff] [review]
Use +id not +android:id. v1

Approval Request Comment
[Feature/regressing bug #]: no idea.
[User impact if declined]: none; this is build only.
[Describe test coverage new/current, TBPL]: none needed, this is build only.
[Risks and why]: none.
[String/UUID change made/needed]: none.
Attachment #8507228 - Flags: approval-mozilla-beta?
Attachment #8507228 - Flags: approval-mozilla-aurora?
Attachment #8507228 - Flags: approval-mozilla-beta?
Attachment #8507228 - Flags: approval-mozilla-beta+
Attachment #8507228 - Flags: approval-mozilla-aurora?
Attachment #8507228 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/fba3e828d330
https://hg.mozilla.org/releases/mozilla-beta/rev/81b50459db25
status-firefox34: --- → fixed
status-firefox35: --- → fixed
status-firefox36: --- → fixed
You need to log in before you can comment on or make changes to this bug.