1084522 - Attribute "layout" has already been defined

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

mobile/android/base/resources/values/attrs.xml:109: error: Attribute "layout" has already been defined

Comment 1

[Richard Newman [:rnewman]]

Attachment: Don't redefine layout attribute in IconTabWidget. v1

This patch renames some "layout" occurrences to "geckolayout" and "buttonlayout" to avoid colliding with -- I presume -- the v7 support library.

This has been reported all over the web. In our case, renaming seems like a fine solution.

Let me know if there's an approach you prefer. This got things building.

Comment 2

[Richard Newman [:rnewman]]

Patch ain't complete:

E/GeckoAppShell( 9370): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoAppShell( 9370): java.lang.RuntimeException: You must supply buttonlayout attribute
E/GeckoAppShell( 9370):         at org.mozilla.gecko.widget.IconTabWidget.<init>(IconTabWidget.java:37)
E/GeckoAppShell( 9370):         at java.lang.reflect.Constructor.constructNative(Native Method)
E/GeckoAppShell( 9370):         at java.lang.reflect.Constructor.newInstance(Constructor.java:417)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.createView(LayoutInflater.java:594)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:696)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.rInflate(LayoutInflater.java:755)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.rInflate(LayoutInflater.java:758)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.rInflate(LayoutInflater.java:758)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.inflate(LayoutInflater.java:462)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.inflate(LayoutInflater.java:397)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.inflate(LayoutInflater.java:353)
E/GeckoAppShell( 9370):         at org.mozilla.gecko.tabs.TabsPanel.inflateLayout(TabsPanel.java:149)
E/GeckoAppShell( 9370):         at org.mozilla.gecko.tabs.TabsPanel.<init>(TabsPanel.java:122)
E/GeckoAppShell( 9370):         at java.lang.reflect.Constructor.constructNative(Native Method)
E/GeckoAppShell( 9370):         at java.lang.reflect.Constructor.newInstance(Constructor.java:417)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.createView(LayoutInflater.java:594)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:696)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.inflate(LayoutInflater.java:469)
E/GeckoAppShell( 9370):         at android.view.LayoutInflater.inflate(LayoutInflater.java:397)
E/GeckoAppShell( 9370):         at android.view.ViewStub.inflate(ViewStub.java:259)
E/GeckoAppShell( 9370):         at org.mozilla.gecko.BrowserApp.ensureTabsPanelExists(BrowserApp.java:1712)

Comment 3

[Richard Newman [:rnewman]]

Attachment: Don't redefine layout attribute in IconTabWidget. v2

Missed the references. This builds. mgoodwin, please test?

Comment 4

[Mark Goodwin [:mgoodwin]]

Not working for me, still. Patches queued:
$ hg qser
0 A attachment.cgi?id=8507204
1 A attachment.cgi?id=8507228
2 A attachment.cgi?id=8507541

Relevant (I think) logcat:
E/GeckoAppShell(10752): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoAppShell(10752): java.lang.RuntimeException: You must supply buttonlayout attribute
E/GeckoAppShell(10752):         at org.mozilla.gecko.widget.IconTabWidget.<init>(IconTabWidget.java:37)
E/GeckoAppShell(10752):         at java.lang.reflect.Constructor.constructNative(Native Method)
E/GeckoAppShell(10752):         at java.lang.reflect.Constructor.newInstance(Constructor.java:417)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.createView(LayoutInflater.java:594)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:696)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.rInflate(LayoutInflater.java:755)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.rInflate(LayoutInflater.java:758)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.rInflate(LayoutInflater.java:758)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.inflate(LayoutInflater.java:462)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.inflate(LayoutInflater.java:397)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.inflate(LayoutInflater.java:353)
E/GeckoAppShell(10752):         at org.mozilla.gecko.tabs.TabsPanel.inflateLayout(TabsPanel.java:149)
E/GeckoAppShell(10752):         at org.mozilla.gecko.tabs.TabsPanel.<init>(TabsPanel.java:122)
E/GeckoAppShell(10752):         at java.lang.reflect.Constructor.constructNative(Native Method)
E/GeckoAppShell(10752):         at java.lang.reflect.Constructor.newInstance(Constructor.java:417)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.createView(LayoutInflater.java:594)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:696)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.inflate(LayoutInflater.java:469)
E/GeckoAppShell(10752):         at android.view.LayoutInflater.inflate(LayoutInflater.java:397)
E/GeckoAppShell(10752):         at android.view.ViewStub.inflate(ViewStub.java:259)
E/GeckoAppShell(10752):         at org.mozilla.gecko.BrowserApp.ensureTabsPanelExists(BrowserApp.java:1712)
E/GeckoAppShell(10752):         at org.mozilla.gecko.BrowserApp.access$1700(BrowserApp.java:133)
E/GeckoAppShell(10752):         at org.mozilla.gecko.BrowserApp$33.run(BrowserApp.java:1606)
E/GeckoAppShell(10752):         at android.os.Handler.handleCallback(Handler.java:730)
E/GeckoAppShell(10752):         at android.os.Handler.dispatchMessage(Handler.java:92)
E/GeckoAppShell(10752):         at android.os.Looper.loop(Looper.java:137)
E/GeckoAppShell(10752):         at android.app.ActivityThread.main(ActivityThread.java:5103)
E/GeckoAppShell(10752):         at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoAppShell(10752):         at java.lang.reflect.Method.invoke(Method.java:525)
E/GeckoAppShell(10752):         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737)
E/GeckoAppShell(10752):         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
E/GeckoAppShell(10752):         at dalvik.system.NativeStart.main(Native Method)

Comment 5

[Mark Goodwin [:mgoodwin]]

namespacing fixed the problem for me. E.g: buttonlayout="@layout/tabs_panel_indicator" becomes: gecko:buttonlayout="@layout/tabs_panel_indicator"

Comment 6

[Richard Newman [:rnewman]]

Attachment: Don't redefine layout attribute in IconTabWidget. v3

Tested on Nexus 10 with new and old tablet UI, and phone.

Doesn't mean it's *right*, but it builds and runs.

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 8507586 [details] [diff] [review]
Don't redefine layout attribute in IconTabWidget. v3

Review of attachment 8507586 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/values/attrs.xml
@@ +105,5 @@
>          </attr>
>      </declare-styleable>
>  
>      <declare-styleable name="TabCounter">
> +        <attr name="geckolayout" format="reference"/>

We should just reuse android:layout here.

@@ +156,5 @@
>          <attr name="doinit" format="boolean"/>
>      </declare-styleable>
>  
>      <declare-styleable name="IconTabWidget">
> +        <attr name="buttonlayout" format="reference"/>

This change is not necessary. Reusing android:layout won't cause any problems.

Comment 8

[Richard Newman [:rnewman]]

Using android:layout:

22:29.48 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/values/attrs.xml:109: error: Attribute "android:layout" has already been defined
22:29.48
22:29.48 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/values/attrs.xml:160: error: Attribute "android:layout" has already been defined

Comment 9

[Richard Newman [:rnewman]]

Attachment: Don't redefine layout attribute in IconTabWidget. v4

This builds.

I had to remove the format argument to avoid a build error. (We're shadowing a declaration from elsewhere, and apparently they have to match.)

Comment 10

[Lucas Rocha (:lucasr)]

(In reply to Richard Newman [:rnewman] from comment #9)
> Created attachment 8508071 [details] [diff] [review]
> Don't redefine layout attribute in IconTabWidget. v4
> 
> This builds.
> 
> I had to remove the format argument to avoid a build error. (We're shadowing
> a declaration from elsewhere, and apparently they have to match.)

Yeah, sorry, I should have mentioned that you shouldn't specify format when reusing an android attribute.

Comment 11

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/caaa0cc9b53d

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/caaa0cc9b53d

Comment 13

[Richard Newman [:rnewman]]

Comment on attachment 8508071 [details] [diff] [review]
Don't redefine layout attribute in IconTabWidget. v4

Approval Request Comment
[Feature/regressing bug #]:
  New tablet work plus old code, in combination with newer Android tools.

[User impact if declined]:
  Developers can't build Aurora or Beta with new Android tools.

[Describe test coverage new/current, TBPL]:
  N/A

[Risks and why]: 
  Low risk; avoid name collision.

[String/UUID change made/needed]:
  None.

Comment 14

[Richard Newman [:rnewman]]

https://tbpl.mozilla.org/?tree=Try&rev=9f53b525c2d5

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8508071 [details] [diff] [review]
Don't redefine layout attribute in IconTabWidget. v4

Beta+
Aurora+

Comment 16

[Richard Newman [:rnewman]]

Attachment: Branch patch for Beta

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d83ccc38a910
https://hg.mozilla.org/releases/mozilla-beta/rev/66297e95dc47