1084565 - Add option to output logcat to stdout

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Marionette client should have a cli argument to output the logcat to stdout. Frankly, this is a stopgap measure for Bug 1069641, but I think it is also valuable to have interlaced logging for debugging purposes.

One way to do this is to clear the logs before running "adb logcat -c", then output the logcat after a test runs, clear the log, and repeat for each test run. You can probably add this to B2GTestResultMixin (https://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/runner/mixins/b2g.py)

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

This may increase test run time. We'll have to monitor that in try, and if it's too long, we can instead dump the log after each test file instead of each test. Or periodically...

Comment 2

[Robert Wood [:rwood]]

Attachment: bug1084565.patch

Thanks for your help on IRC!

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8508256 [details] [diff] [review]
bug1084565.patch

Review of attachment 8508256 [details] [diff] [review]:
-----------------------------------------------------------------

Other than that, this looks really good!

::: testing/marionette/client/marionette/runner/base.py
@@ +211,5 @@
>                  if dm_type == 'adb':
> +                    dm = get_dm(self.marionette)
> +                    self.b2g_pid = get_b2g_pid(dm)
> +                    if self.logcat_stdout:
> +                        dm.shellCheckOutput(['/system/bin/logcat', '-c'])

on second thought, we should just clear the logcat after we write it instead of here. That way, all the logcat that existed before the test will be outputted, which could be useful for debugging if an error occurred in gecko/gaia before the tests even run.

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

and 1am is a perfectly reasonable time to do patch reviews.

Comment 5

[Robert Wood [:rwood]]

Attachment: bug1084565_take2.patch

Thanks Mdas! Hope this one is a more reasonable hour haha

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8508712 [details] [diff] [review]
bug1084565_take2.patch

Review of attachment 8508712 [details] [diff] [review]:
-----------------------------------------------------------------

awesome, thanks!

Comment 7

[Robert Wood [:rwood]]

https://tbpl.mozilla.org/?tree=Try&rev=28b4d649967a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0186ba5fc0c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0186ba5fc0c

Comment 10

[Malini Das [:mdas] - Away, not checking bugmail]

We need to uplift this to everything mozharness/scripts/marionette.py  touches...

Comment 11

[Malini Das [:mdas] - Away, not checking bugmail]

Marking myself as ni? to uplift

Comment 12

[Malini Das [:mdas] - Away, not checking bugmail]

mozharness scripts will be per branch, and we can update them by request. There isn't a need right now.