1084622 - pass campaign to fxa content server when opening about:accounts

Status: RESOLVED DUPLICATE of bug 1244929

(Firefox :: Firefox Accounts, defect, P2)

Description

[Katie Parlante]

Similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1053939, we want sync promotions to be able to pass a campaignId on to the content server, so that we can link the campaign to rates of FxAccount creation, etc.

Comment 1

[Katie Parlante]

Chris, is "campaignId" good enough, or do you want to pass along more parameters?

Comment 2

[Chris Karlof [:ckarlof]]

(In reply to Katie Parlante from comment #1)
> Chris, is "campaignId" good enough, or do you want to pass along more
> parameters?

FWIW, I would go with "campaign" instead of "campaignId" (the Id is unnecessary, I think). We already have terrible mix of camel case and snake case due to different protocol conventions, and I'd rather not take an opinion on a new param unless it adds value. 

I'm assuming the "do you want to pass along more parameters" question is for chris more.

Comment 3

[Chris More [:cmore]]

(In reply to Chris Karlof [:ckarlof] from comment #2)
> (In reply to Katie Parlante from comment #1)
> > Chris, is "campaignId" good enough, or do you want to pass along more
> > parameters?
> 
> FWIW, I would go with "campaign" instead of "campaignId" (the Id is
> unnecessary, I think). We already have terrible mix of camel case and snake
> case due to different protocol conventions, and I'd rather not take an
> opinion on a new param unless it adds value. 
> 
> I'm assuming the "do you want to pass along more parameters" question is for
> chris more.

campaign should be suffice. 

Would it be something like this:

&entrypoint=abouthome&campaign=fx2014

As long as we could pass any alphanumeric string from about:home snippets so that we can A/B test snippets->account conversion rates and test the effectiveness of overall snippet campaigns, it should be fine.

Comment 4

[Katie Parlante]

(In reply to Chris More [:cmore] from comment #3)
> campaign should be suffice. 
> 
> Would it be something like this:
> 
> &entrypoint=abouthome&campaign=fx2014
> 
> As long as we could pass any alphanumeric string from about:home snippets so
> that we can A/B test snippets->account conversion rates and test the
> effectiveness of overall snippet campaigns, it should be fine.

Yes, just like that. ckarlof logged the server-side issue here: https://github.com/mozilla/fxa-content-server/issues/1792

Comment 5

[Edwin Wong [:edwong]]

shane - is this done already? if so let's close it out.

Comment 6

[Shane Tomlinson [:stomlinson]]

edwong, this is a question markh should be able to answer. A quick search of https://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-syncui.js makes me believe no.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Nope, this isn't done (but I guess it does beg the question of whether we actually need it given no one has noticed until now ;)

What I don't see here is how Firefox obtains this campaign ID so it can pass it back to about:accounts. We we are talking about snippets, so the relevant code is https://dxr.mozilla.org/mozilla-central/source/browser/modules/AboutHome.jsm#167 - we'd need the AboutHome:Sync message sent by the snippet to include this ID in the message and we'd just pass it on. I can see the bug for the server to collect this campaign ID, but can't see the bug that would pass this ID down to us so we can pass it back for the server to collect.

Katie, can you help us here? It may be that this ID is already being passed to us, but I'm not sure how to check and I can't seem to force a sync-related snippet to appear.

Comment 8

[Shane Tomlinson [:stomlinson]]

Thanks markh for the response. With the new firstrun flow in Fx 40, I suspect this request may become less of a priority. 

The Fx 40 firstrun flow will embed an FxA/Sync iframe directly into the firstrun page; about:accounts will not be involved. The firstrun folks can add/update a campaign ID when they set the iframe src.

Add to that the stated UX goal of replacing about:accounts with content directly embedded in the preferences panel, this request might be more effort than it's worth.

Comment 9

[Katie Parlante]

I'm passing this back to cmore, who has more context about when this is needed and who has the campaign id to pass on. Its implemented on the server.

Comment 10

[Chris More [:cmore]]

We should see if we can consume utm_source, utm_medium, utm_campaign and utm_content so we can attribute acquisition of accounts by the same source/medium/campaign/content that we do now on websites.

Since we only have a campaign tag now in FxA, we would have to have additional fields to capture that info?

Comment 11

[Mark Hammond [:markh] [:mhammond]]

I'm fairly sure this is a dupe of bug 1244929 and bug 1250758 - please reopen if that's not the case.