1084627 - popcorn editor spinner does not disappear

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[not.m.schneider]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.104 Safari/537.36

Steps to reproduce:

search for "test"
switch to youtube tab
search for "bug"
switch very fast to soundcloud tab
wait for results to appear
switch back to youtube tab


Actual results:

the cat/spinner is still there


Expected results:

it shouldn't be

Comment 1

[not.m.schneider]

Attachment: github pull request

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/5f42763bc218e43a9c1a854a04ce07d80be4f66e
bug 1084627 - fixed media gallery spinner not becoming hidden

when two tabs contained a spinner image after starting searches with
different tabs activated only the spinner in the first tab would get
disabled.

Comment 3

[Scott [:thecount] Downe]

Landed: https://github.com/mozilla/popcorn.webmaker.org/commit/5f42763bc218e43a9c1a854a04ce07d80be4f66e

I'll mark this as verified when it's live on popcorn.webmaker.org