popcorn editor spinner does not disappear

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: not.m.schneider, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.104 Safari/537.36

Steps to reproduce:

search for "test"
switch to youtube tab
search for "bug"
switch very fast to soundcloud tab
wait for results to appear
switch back to youtube tab


Actual results:

the cat/spinner is still there


Expected results:

it shouldn't be
(Reporter)

Comment 1

4 years ago
Created attachment 8507210 [details] [review]
github pull request
(Reporter)

Updated

4 years ago
Attachment #8507210 - Flags: review?
Attachment #8507210 - Flags: review? → review?(scott)

Comment 2

4 years ago
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/5f42763bc218e43a9c1a854a04ce07d80be4f66e
bug 1084627 - fixed media gallery spinner not becoming hidden

when two tabs contained a spinner image after starting searches with
different tabs activated only the spinner in the first tab would get
disabled.
Landed: https://github.com/mozilla/popcorn.webmaker.org/commit/5f42763bc218e43a9c1a854a04ce07d80be4f66e

I'll mark this as verified when it's live on popcorn.webmaker.org
Status: UNCONFIRMED → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
Flags: needinfo?(scott)
Attachment #8507210 - Flags: review?(scott)
You need to log in before you can comment on or make changes to this bug.