DNS: Enable getting TTL by default for Windows

RESOLVED FIXED in mozilla36

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: sworkman, Assigned: sworkman)

Tracking

36 Branch
mozilla36
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Code was added in Bug 1067679 to asynchronously obtain the TTL from DNS records - we should try enabling it by default.
 - Based on bug reports and complaints from external folk enabling this by default should mean our DNS records time out more accurately.
 - A subset of our Nightly users have had this enabled for about a month now with no known issues.
 - Telemetry has shown a slight decrease in cache hit rate, but we think catching the corner cases that rely on TTL might be more important.
- Removed DNS experiment variants.
- TTL enabled by pref "network.dns.get-ttl" - only enabled on Windows by default.
Attachment #8507243 - Flags: review?(mcmanus)
Comment on attachment 8507243 [details] [diff] [review]
v1.0 Enable DNS TTL by default on Windows

Review of attachment 8507243 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: modules/libpref/init/all.js
@@ +1492,5 @@
>  
>  // In the absence of OS TTLs, the DNS cache TTL value
>  pref("network.dnsCacheExpiration", 60);
>  
> +#ifdef XP_WIN

I would drop the ifdef and just comment that this only has partial platform support.. on unsupported platforms its a nop
Attachment #8507243 - Flags: review?(mcmanus) → review+
Blocks: 820391
No longer blocks: 151929
https://hg.mozilla.org/mozilla-central/rev/b1c4aac68d3c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Depends on: 1115219
Hi all, 
Have just received a support request from a user on the release channel. There appears to be some conflict between this new DNS behaviour and Comodo firewall: 
https://support.mozilla.org/en-US/questions/1049324

Please advise.
(In reply to josh from comment #6)

josh, your report (inbound tcp) doesn't make a lot of sense to me as something firefox should be responsible for.. but see bug 1093983 as we'll be changing the behavior that likely triggers this.
You need to log in before you can comment on or make changes to this bug.