Make reftest-analyzer.xhtml support test/reference images of arbitrary dimensions

RESOLVED FIXED in mozilla36

Status

Testing
Reftest
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

layout/tools/reftest/reftest.js hardcodes gBrowser to a size of 800x1000, and reftest-analyzer.xhtml hardcodes these values too. That means that highlighting of differences and getting pixel differences on hover are completely broken for other reftesting harnesses that use different dimensions (such as test_reftests_with_caret.html, which uses 600x600). That's...really annoying, especially when the differences are subtle and you really need the highlighting/hover features to work.
Created attachment 8507269 [details] [diff] [review]
patch
Attachment #8507269 - Flags: review?(dholbert)
Created attachment 8507295 [details] [diff] [review]
patch
Attachment #8507269 - Attachment is obsolete: true
Attachment #8507269 - Flags: review?(dholbert)
Attachment #8507295 - Flags: review?(dholbert)
Attachment #8507295 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/dd11d04e841c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.