1084843 - For locales where first day of week is Monday, Repeat feature for alarms is broken

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Théo Chevalier]

STR:

1. Switch to French
2. Open Clock
3. Create a new alarm
4. Set Repeat to Lundi (Monday)
5. Tap OK

Actual result:
In the select box, "Dim" ("Sun") is selected

Expected result:
 "Lun" ("Mon") is selected

Comment 1

[Théo Chevalier]

[Blocking Requested - why for this release]:

2.2 and 2.1 are affected (just checked), and this affects several Tako shipping locales with very high priority.
All locales with "1" are affected: http://transvision.mozfr.org/string/?entity=shared/date/date.properties:weekStartsOnMonday&repo=gaia

If the user doesn't read the select box after clicking on "OK", the alarm will be set for the *wrong* day. Having an alarm not ringing on selected days is really annoying and frustrating.

Comment 2

[Dylan Oliver [:doliver]]

triage: badly broken, surprising this hasn't been reported before. will take this on for 2.1.

Comment 3

[Marcus Cavanaugh [:mcav]]

Attachment: Gaia PR with test

On the bright side, this was a display-only problem. The summary display did not pull the correct l10n-ids when weekStartsOnMonday was true. "weekday-0-short" is always Sunday, no matter what, so that index needs to be specified relative to a world where the week always starts on sunday.

Tested with a unit test (fails without the patch) + manual verification.

Comment 4

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8510435 [details] [review]
Gaia PR with test

I'm not a huge fan of constants/dictionaries but change is small enough and better than the string concatenation that we had before.. unit tests should also catch regressions. so r+ from me.

Comment 5

[Marcus Cavanaugh [:mcav]]

Thanks, Miller.

master: https://github.com/mozilla-b2g/gaia/commit/992cbf640b64e73c4c5d15a21d465875dcf3f372

Comment 6

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8510435 [details] [review]
Gaia PR with test

[Approval Request Comment]

Without this patch, the clock alarm's "repeat" button will show the incorrect date for locales where weekStartsOnMonday is true. Simple patch, well-tested, low risk.

[Bug caused by] (feature/regressing bug #): unknown
[User impact] if declined: Users may think the alarm repeat feature is broken.
[Testing completed]: manual + unit test
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/dd7a20ee5d867e34c3378481d481d40172fb7dff

Comment 8

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1 and 2.2.

Result: Correct day is displayed on the "New alarm" screen. Tested on French, Italian, German, Dutch, and Danish.

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141104001202
Gaia: 8b0cf889ae0d48a9eb7ecdcb9b67590de45cc5e5
Gecko: 388b03efe92d
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141104040207
Gaia: 3c50520982560ccba301474d1ac43706138fc851
Gecko: 54d05732f29b
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0