Closed
Bug 1085030
Opened 10 years ago
Closed 10 years ago
Focus the related bugs text field while opening it every time, not just the first time
Categories
(Tree Management :: Treeherder, enhancement, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: philor, Assigned: jfrench)
References
()
Details
Attachments
(1 file)
When you click the "+" next to "Related bugs" to manually add a bug number, there are two things you might do next: * 99.99% of the time, click in the text field to focus it * 00.01% of the time, say "where's my new drink? isn't that the icon to get another drink delivered to me? waitress! where's my drinkie-poo?" We should optimize for the more common case, by focusing the text field.
Reporter | ||
Comment 1•10 years ago
|
||
Okay, finally paid enough attention to the "hey, wait, didn't it focus itself that time?" thing to realize that we do focus it, the first time it is opened during a session, we just don't focus it after the first time.
Summary: Focus the related bugs text field while opening it → Focus the related bugs text field while opening it every time, not just the first time
Updated•10 years ago
|
Blocks: treeherder-dev-transition, 1059368
Priority: -- → P2
Assignee | ||
Comment 2•10 years ago
|
||
I think I have this sorted, once sure I'll assign myself. Phil's descriptions are awesome :)
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 3•10 years ago
|
||
Please see the above PR for review and status.
Attachment #8516902 -
Flags: review?(wlachance)
Comment 4•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/9051c9e08c4dbd8038593fdf41bd34b5446628b8 Bug 1085030 - Refocus bug entry on subsequent additions https://github.com/mozilla/treeherder-ui/commit/49ac6ba52ec0c785c87a752c4b6398b76b652bdc Merge pull request #259 from tojonmz/refocus-bug-entry Bug 1085030 - Refocus bug entry on subsequent additions
Comment 5•10 years ago
|
||
Comment on attachment 8516902 [details] [review] treeherder-ui-PR#259 Looks good, works well... merged!
Attachment #8516902 -
Flags: review?(wlachance) → review+
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•10 years ago
|
||
Verified fixed and working correctly on stage on Firefox 33.1. Unable to verify on Chrome due to bug 1072346 (job panel not opening).
Status: RESOLVED → VERIFIED
Comment 7•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/f020745591d6d996ed47a08ab155d399083c7616 Bug 1085030 - Refocus bug entry on subsequent additions https://github.com/mozilla/treeherder/commit/d60227b55ae496c8f946a379242d6b016b54c2c8 Merge pull request #259 from tojonmz/refocus-bug-entry Bug 1085030 - Refocus bug entry on subsequent additions
You need to log in
before you can comment on or make changes to this bug.
Description
•