1085144 - B2G OS X bootstrap script is not configured for OS X 10.10 (Yosemite)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Infrastructure, defect)

Description

[emil]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141019030207

Steps to reproduce:

# On OS X 10.10 (Yosemite)
git clone https://github.com/mozilla-b2g/B2G
cat B2G/scripts/bootstrap-mac.sh | bash


Actual results:

The bootstrap-mac.sh script assumes that the latest OS X product version is 10.9 (e.g. $osx_version != "10.9").

It lacks support for detecting 10.10 SDK and is unable to correctly detect that 10.10 is a successor to 10.6 (e.g. $osx_version \> "10.6")


Expected results:

The bootstrap script should be able to handle OS X 10.10 properly.

Comment 1

[emil]

Attachment: Pull request with proposed fix

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8507544 [details] [review]
Pull request with proposed fix

I have no way to test that, sorry. Redirecting to mwu.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8507544 [details] [review]
Pull request with proposed fix

That passed on Yosemite even with XCode 6.1.

To build Firefox OS emulator on Mac, we need sdk_version 10.8 or lower, and one can still download older version of Xcode for emulator builds. However, I have no more access to flame-kk system backup, so I cannot verify building physical devices for you.

Therefore, I don't have a successful full system build with this pull request merged, so I cannot give a r+ here. I would if I could. Thank you.

Fabrice, could you help redirect the review again?

Comment 4

[[:fabrice] Fabrice Desré]

Michael, you're the only one I know that sometimes build on Mac... feel free to redirect if you can't verify.

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 8507544 [details] [review]
Pull request with proposed fix

Looks ok to me.

Haven't tested this, but it seems better with this fix than without, so r=me. If there are more issues, we can followup in other bugs.

Comment 6

[emil]

Ping.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Marking new because I can replicate

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Based on mwu's review+, I merged the pull request after giving it a whirl myself for the bootstrap.
https://github.com/mozilla-b2g/B2G/commit/943f75de441ea73086f6663523e9ef5fd0900f2a

note, I haven't tested making a build yet with this; concerns are that we may need to downgrade to 10.8 for emulators.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Thanks for the report and the patch!

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Turns out also that 10.6 SDK url link is broken and finding 10.6 is broken.  This is followed up in bug 875600.