Via bug 1085146 i noticed that we use a fake appinfo in test_TelemetryPing.jsm, which means that we can't actually use appinfo.isOfficial (meaning we skip a check). A better approach would probably be to use AppInfo.jsm later and make that work properly for properties that are not overridden.
Created attachment 8507555 [details] [diff] [review] Use the original appinfo as the prototype One possible approach: just use the original appinfo as the prototype of the fake appinfo (so we just get the original values for everything we don't overwrite). https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=199be957793e https://tbpl.mozilla.org/?tree=Try&rev=199be957793e
Attachment #8507555 - Flags: review?(nfroyd)
Attachment #8507555 - Flags: review?(nfroyd) → review+
sorry had to backout this cset in https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=2a037ad0ab7a since this or the other bug caused test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3164441&repo=mozilla-inbound
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.