Expose isOfficial in fake telemetry appinfo

RESOLVED FIXED in mozilla36

Status

()

Toolkit
Telemetry
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gfritzsche, Assigned: gfritzsche)

Tracking

unspecified
mozilla36
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Via bug 1085146 i noticed that we use a fake appinfo in test_TelemetryPing.jsm, which means that we can't actually use appinfo.isOfficial (meaning we skip a check).

A better approach would probably be to use AppInfo.jsm later and make that work properly for properties that are not overridden.
(Assignee)

Updated

4 years ago
Assignee: nobody → georg.fritzsche
(Assignee)

Comment 1

4 years ago
Created attachment 8507555 [details] [diff] [review]
Use the original appinfo as the prototype

One possible approach: just use the original appinfo as the prototype of the fake appinfo (so we just get the original values for everything we don't overwrite).

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=199be957793e
https://tbpl.mozilla.org/?tree=Try&rev=199be957793e
Attachment #8507555 - Flags: review?(nfroyd)
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Depends on: 1073536
Attachment #8507555 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/372d56a84113
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.