media/webrtc/trunk/webrtc/system_wrappers/source/cpu_features_android.c is only built on Android

NEW
Unassigned

Status

()

Core
WebRTC
3 years ago
2 years ago

People

(Reporter: glandium, Unassigned)

Tracking

unspecified
ARM
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
Considering the file name, it sounds fair, except what the file implements is WebRtc_GetCPUFeaturesARM, which is used on all ARM builds:

../../../media/webrtc/trunk/webrtc/common_audio/common_audio_common_audio/Unified_c_n_audio_common_audio1.o: In function `InitFunctionPointers':
/«PKGBUILDDIR»/media/webrtc/trunk/webrtc/common_audio/signal_processing/spl_init.c:105: undefined reference to `WebRtc_GetCPUFeaturesARM'
../../../media/webrtc/trunk/webrtc/common_audio/common_audio_common_audio/Unified_cpp_n_audio_common_audio0.o: In function `webrtc::SincResampler::InitializeCPUSpecificFeatures()':
/«PKGBUILDDIR»/media/webrtc/trunk/webrtc/common_audio/resampler/sinc_resampler.cc:142: undefined reference to `WebRtc_GetCPUFeaturesARM'
../../../media/webrtc/trunk/webrtc/modules/modules_audio_processing/aecm_core.o: In function `WebRtcAecm_InitCore':
/«PKGBUILDDIR»/media/webrtc/trunk/webrtc/modules/audio_processing/aecm/aecm_core.c:536: undefined reference to `WebRtc_GetCPUFeaturesARM'
../../../media/webrtc/trunk/webrtc/modules/modules_audio_processing/Unified_c_les_audio_processing0.o: In function `WebRtcNsx_InitCore':
/«PKGBUILDDIR»/media/webrtc/trunk/webrtc/modules/audio_processing/ns/nsx_core.c:775: undefined reference to `WebRtc_GetCPUFeaturesARM'
collect2: error: ld returned 1 exit status
make[5]: *** [libxul.so] Error 1
I don't know on which OS you are trying to build Fx on. So I'm also not sure what you are asking here for. But adding your platform to this line should hopefully help:
http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/system_wrappers/source/system_wrappers.gyp#200
(Reporter)

Comment 2

3 years ago
(In reply to Nils Ohlmeier [:drno] from comment #1)
> I don't know on which OS you are trying to build Fx on.

Plain Linux ARM.

> So I'm also not sure what you are asking here for. But adding your platform to this line should
> hopefully help:
> http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/
> system_wrappers/source/system_wrappers.gyp#200

That also contains android specific stuff, though.
(In reply to Mike Hommey [:glandium] from comment #2)
> (In reply to Nils Ohlmeier [:drno] from comment #1) 
> > So I'm also not sure what you are asking here for. But adding your platform to this line should
> > hopefully help:
> > http://dxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/
> > system_wrappers/source/system_wrappers.gyp#200
> 
> That also contains android specific stuff, though.

Extending it like this for example:
 ['OS=="android" or moz_widget_toolkit_gonk==1 or OS=="linux"' , {
should hopefully get you around your linking issue.
Or probably even better:
  ['OS=="android" or moz_widget_toolkit_gonk==1 or target_arch=="arm"' , {
Is this still relevant?
backlog: --- → parking-lot
Flags: needinfo?(mh+mozilla)
(Reporter)

Comment 6

2 years ago
It happens the issue was kind of fixed by bug 1066853, but it hardcoded the result instead of checking /proc/cpuinfo like what the android stuff does.
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.