1085197 - Magnet link shows as blank/nameless tab after update from v32 to v33.

Status: NEW

(Firefox :: Tabbed Browser, defect)

Description

[FE]

Attachment: firefox_bugreport_2014oct19.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.93 Safari/537.36

Steps to reproduce:

Middle-clicked on a magnet link to load in a background tab.


Actual results:

The magnet link correctly opened; however, the tab name is blank -- it shows as an empty hole in the tab list. (See screenshot, third tab from right.)


Expected results:

The magnet link should correctly open and the tab name should show "manget://....." and the tab should actually appear as a tab, not just a hole in the tab list.

Comment 1

[Loic]

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e86b84998b18&tochange=a19e0434ea52

Maybe a dupe of bug 1059600 (anyway, similar issue).

Comment 2

[Brian R. Bondy [:bbondy]]

I'll take a look

Comment 3

[Dão Gottwald [:dao]]

I think ideally we would avoid opening tabs for links we hand off to external protocol handlers, or at least close the tabs automatically when realizing that they're useless...

Comment 4

[Dão Gottwald [:dao]]

This is a minor regression, I don't think we need to track it.

Comment 5

[FE]

Ideally, I agree with Mr. Gottwald; however, let's be 100% consistent.  Because, unfortunately, middle-clicking a torrent file or an externally-handled PDF file leaves --essentially-- an empty "New Tab" labeled tab.  If the ultimate goal is consistency, then let it be across the board...that any externally-handled link, magnet, torrent, PDF, or whatever not be shown as a "New Tab" or a blank/empty tab.

On the other hand, if consistency is the goal or true measure, then all of the mentioned link types continue to respond consistently and as they always have to a middle-click; especially, with regard to the regression -- from FireFox version 33 up to and including version 36.  In other words, if it's wrong, at least it's consistently wrong.  Even if not ideal by my reckoning, I readily accept that.  "Feature, not bug."