1085201 - [Flame][Tako][v2.1][Settings] "Searching device" not hidden as Sony SBH50 BTHS paired via NFC

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[William Hsu [:whsu]]

+++ This bug was initially created as a clone from a confidential Bug #1076595 +++

User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.124 Safari/537.36

== Issue Description ==
If to pair Sony SBH50 BTHS with a phone using NFC, the Bluetooth settings window will show "Searching for devices..."
message even when SBH50 status is set as "Connected to phone/media audio"(see the attached screenshot) 

100% reproducible for me in case when NFC paring is done when Bluetooth is switched off. 

== Preconditions ==
 - Bluetooth is switched OFF in the phone 
 - NFC is switched ON 
 - phone screen displaying Bluetooth settings 

== STEPS == 
 1) Perform NFC touch between SBH50 and  phone 
 2) Wait until pairing and connection is done 
 3) Check the "Devices in the area" section of Bluetooth settings 


* Actual results:
  There will be a "searching for devices..." message, however no real search is performed(and needed)


* Expected results:
  "searching for devices" should be hidden, and "Search for devices" button should be enabled.

Comment 1

[William Hsu [:whsu]]

Alison has helped confirm this bug.

--- Quote Alison's information from Bug #1076595 ---
This issue is also reproduce on 
[Flame v2.0]
Gaia-Rev        9c7dec14e058efef81f2267b724dad0850fc07e4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c17df9fe087d
Build-ID        20141019000201
Version         32.0

[Flame v2.1]
Gaia-Rev        76070c98dd0068324938c79bede50fe6d90bd996
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/a966f9f6e3ac
Build-ID        20141019001201
Version         34.0

Comment 2

[William Hsu [:whsu]]

John provided a patch. Please help review it and submit a pull request.
Thanks.

==== == = Quote John's information (Bug #1076595) ==== == = 
bluetooth.js  for reference
----------------------------------------------------------------
    function startDiscovery() {
      if (!bluetooth.enabled || !defaultAdapter ||
          discoverTimeout || document.hidden) {
        return;
      }

      var req = defaultAdapter.startDiscovery();
      req.onsuccess = function bt_discoveryStart() {
        if (!discoverTimeout)
          discoverTimeout = setTimeout(stopDiscovery, discoverTimeoutTime);
      };
      req.onerror = function bt_discoveryFailed() {
        console.error('Can not discover nearby device');
        stopDiscovery(); // Arima.JohnHsu

      };
    }

    function stopDiscoveryWhenLeaveApp() {
      //only stop discovery when Settings app is hidden
      if (!document.hidden)
        return;
      stopDiscovery();
    }

    function stopDiscovery() {
      if (!bluetooth.enabled || !defaultAdapter || !discoverTimeout) {
        searchingItem.hidden = true;     // Arima.JohnHsu
        searchAgainBtn.disabled = false; // Arima.JohnHsu
        return;
      }

Comment 4

[Alison Shiue]

[Blocking Requested - why for this release]:
Functional issue, "searching for devices" does not work in this situation.

Comment 5

[Francis Lee [:frlee]]

hi Shawn,

would you please kindly comment on this issue?

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This is relate to Settings. ni Ian

Comment 7

[[e-mail], [e-mail]]

I'm not able to reproduce the issue on 2.2 because there is no confirmation dialog of NFCConnectBTenable.

Build version:

Gaia-Rev        4d7f051cede6544f4c83580253c743c22b0cb279
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/4c449dcda453
Build-ID        20141021185231
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141021.221631
FW-Date         Tue Oct 21 22:16:44 EDT 2014
Bootloader      L1TC10011800

I will try the issue again on v2.1.

Comment 8

[Alison Shiue]

(In reply to Ian Liu [:ianliu] from comment #7)
> I'm not able to reproduce the issue on 2.2 because there is no confirmation
> dialog of NFCConnectBTenable.
bug 1086175 is tracking this issue.

Comment 9

[[e-mail], [e-mail]]

Attachment: pull request 25396

Arthur, this is a rare case for enabling bluetooth via NFC pairing. The bluetooth panel will start to discovery devices while Bluetooth is enabled. In the same time, the request is failed caused by NFC/Bluetooth pairing process. So that there is no 'ondiscoverystatechanged' event coming. We have to reset search button/description if we request startDiscovery() in failed case. Could you please help to review the pull request? Thanks:)

Comment 10

[[e-mail], [e-mail]]

(In reply to William Hsu [:whsu] from comment #2)
> John provided a patch. Please help review it and submit a pull request.
> Thanks.
> 
> ==== == = Quote John's information (Bug #1076595) ==== == = 
> bluetooth.js  for reference
> ----------------------------------------------------------------
Thanks for John's patch. The patch is working fine. But I would like to have a simply fix. Since request startDiscovery() in failed case, it usually means Bluetooth module is not discovering. I have no reason to request stopDiscovery() in this case. Anyway, thanks for investigation.:)

Comment 11

[[e-mail], [e-mail]]

(In reply to William Hsu [:whsu] from comment #2)
> John provided a patch. Please help review it and submit a pull request.
> Thanks.
> 
> ==== == = Quote John's information (Bug #1076595) ==== == = 
> bluetooth.js  for reference
> ----------------------------------------------------------------
Thanks for John's patch. The patch is working fine. But I would like to have a simply fix. Since request startDiscovery() in failed case, it usually means Bluetooth module is not discovering. I have no reason to request stopDiscovery() in this case. Anyway, thanks for investigation.:)

Comment 12

[Dietrich Ayala (:dietrich)]

Triage determined blocking+ because broken new feature - these will be first release that NFC APIs are available to non-certified apps.

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8509338 [details] [review]
pull request 25396

Makes sense, r=me.

Comment 15

[[e-mail], [e-mail]]

Gaia/master:  a080b927ef36056919538e9ad6305948d681165f

Comment 16

[[e-mail], [e-mail]]

Comment on attachment 8509338 [details] [review]
pull request 25396

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1085201
[User impact] if declined: Cannot trigger to search bluetooth devices via search button. And the status of searching device is wrong.
[Testing completed]: Pass on try-server.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None.

Comment 17

[[e-mail], [e-mail]]

Comment on attachment 8509338 [details] [review]
pull request 25396

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1085201
[User impact] if declined: Cannot trigger to search bluetooth devices via search button. And the status of searching device is wrong.
[Testing completed]: Passed on try-server.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None.

Comment 18

[bhavana bajaj [:bajaj]]

Comment on attachment 8509338 [details] [review]
pull request 25396

Can QA verify once this lands on 2.1? Setting NI on Allison.

Comment 19

[bhavana bajaj [:bajaj]]

Why is this needed on 2.0? Is this a regression caused there and we discovered that we broke it now ? Does it happen with Sony specific Bluetooth headsets only?

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/005c3c096472c6c5faf97eece289ed37e00145a8

Comment 21

[Alison Shiue]

Verified on 
[2.1]
Gaia-Rev        c97463d61f45513a2123b19610386ddbfc916819
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/4f8c0c021128
Build-ID        20141026161201
Version         34.0

[2.2]
Gaia-Rev        e91d99e4d96954f06383c00bb9d79598a697e310
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/8230834302c9
Build-ID        20141026160206
Version         36.0a1

Comment 22

[William Hsu [:whsu]]

Thanks Alison! :D

Comment 23

[[e-mail], [e-mail]]

(In reply to bhavana bajaj [:bajaj] from comment #19)
> Why is this needed on 2.0? Is this a regression caused there and we
> discovered that we broke it now ? Does it happen with Sony specific
> Bluetooth headsets only?

* The bug is happened while pairing with headset via NFC. I see we support to pair with devices via NFC from v2.0.(https://github.com/mozilla-b2g/gaia/blob/v2.0/apps/system/js/system_nfc_connect_dialog.js)
* This might not a regression because we don't handle the error case of startDiscovery() in the old case base for a long time.
* The issue happens with NFC headset. Not only Sony SBH50 BTHS.

Comment 24

[bhavana bajaj [:bajaj]]

Comment on attachment 8509338 [details] [review]
pull request 25396

Please verify once this lands on 2.0

Comment 25

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/92991dbfc092448591218f09046d1d89fd96be84