1085233 - Value selector does not need to give back focus to the app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #1079728 +++

See bug 1079728 comment 8. Since Value Selector, as an overlay, never takes the focus away, it shouldn't call frame.focus() when it closes.

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#25305

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8507693 [details] [review]
mozilla-b2g:master PR#25305

In additional to the 3-line patch, move some test files to ensure they runs automatically with our unit test server.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8507693 [details] [review]
mozilla-b2g:master PR#25305

There was no test for the original focus..? anyway r+

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/47faa4651f8feb11152ef475850cc9641fd5cbeb

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7eb2e1b1bd98

Comment 5

[GitHub Autolander Bot]

Attachment: [PullReq] timdream:sleep-menu-focus to mozilla-b2g:master

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Patch backed out due to bug 1128053:

master: https://github.com/timdream/gaia/commit/a785391616adb07777dd0e94c8bd52d432d8fdd9
v2.2: https://github.com/timdream/gaia/commit/b29f3ae643d57f3fb24ed7e9fb6884d7f2fc533d

Comment 7

[Kevin Grandon :kgrandon]

I've unfortunately had to re-apply this patch to master for breaking integration tests. (If we don't then the alternative is to close the tree.)

https://github.com/mozilla-b2g/gaia/commit/5cb6e0921c9387d3c8672f9fa2a14085ac62696e

Updating tracking flags to capture this.

Comment 8

[Kevin Grandon :kgrandon]

Also broke v2.2 tests, so reverted: https://github.com/mozilla-b2g/gaia/commit/653dcb9ac590ed55042f24fcf234f27b7ea40f79

Example of failure: http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/b2g-inbound-linux64_gecko/1423061425/b2g-inbound_ubuntu64_vm-b2gdt_test-gaia-js-integration-3-bm67-tests1-linux64-build157.txt.gz

Comment 9

[Kevin Grandon :kgrandon]

Sorry, flipped flags the wrong way.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

revert patches reapplied on master and v2.2.

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

De-assigning myself since this bug need an exhaust fix on focus management before we could safely re-apply the patch, and I shouldn't be the person driving that fix.

Comment 12

[BMO Automation]

Firefox OS is not being worked on