If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update expected audio_channel in test_dialer_make_call

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: zac, Assigned: zac)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
Bebe
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Bug 1041594 has resolved a race condition in the audio channel.

test_dialer_make_call is checking the wrong value.

Update the test to check the correct, non racey value.
(Assignee)

Comment 1

3 years ago
Created attachment 8507797 [details] [review]
github pr

Only merge this when https://bugzilla.mozilla.org/show_bug.cgi?id=1041594 hits mozilla-central.
Attachment #8507797 - Flags: review?(florin.strugariu)
Comment on attachment 8507797 [details] [review]
github pr

LGTM
Attachment #8507797 - Flags: review?(florin.strugariu) → review+
This has been merged in Mozilla-central
https://github.com/mozilla-b2g/gaia/commit/65a28b5684919f6392daad2fdd58ec97abd28ea4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.