1085304 - STK Call control to emergency call not indicated correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Vendcom, defect)

Description

[christopher.posselwhite]

Attachment: Logs, both QXDM and adb ones.

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141013195847

Steps to reproduce:

Set up a call and let the SIM respond with call allowed, with modifications, to an emergency number.


Actual results:

The call is set up, but it is not indicated as emergency call.


Expected results:

Call should be indicated as an emergency call,.

Comment 1

[Olof Wickström]

This is a violation of a type approval test case:

TA - 27.22.6.1.4-1.8 CALL CONTROL BY SIM , set up call attempt by user, allowed with modifications emergency call

Please fix for 2.1

Comment 2

[howie [:howie]]

Hi Fernando, may need your help here, thank you.

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Can you provide log traces with "GAIA DEBUG TRACES" setting enabled? (this is inside the developers menu)
Thank you.

Also I suspect this is not STK bug but Dialer one. The STK code only informs the modem to setup the call to a phone number, then gecko sends a System Message to the dialer app to attend it.

Adding Etienne as Dialer peer.

Comment 4

[christopher.posselwhite]

Attachment: Logs with Gaia debug trace

Comment 5

[Etienne Segonzac (:etienne)]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #3)
> Can you provide log traces with "GAIA DEBUG TRACES" setting enabled? (this
> is inside the developers menu)
> Thank you.
> 
> Also I suspect this is not STK bug but Dialer one. The STK code only informs
> the modem to setup the call to a phone number, then gecko sends a System
> Message to the dialer app to attend it.
> 
> Adding Etienne as Dialer peer.

Or even a gecko issue...
The code to display the "emergency" message on the callscreen is really straightforward and only dependent on a flag set by gecko [1]. So if it works when manually dialing an emergency number, but not via STK it will probably require a gecko fix.

[1] https://github.com/mozilla-b2g/gaia/blob/3d9cc667f4e929861a9a77c41096bbf5a9c1bde0/apps/callscreen/js/handled_call.js#L144

Comment 6

[Dietrich Ayala (:dietrich)]

Certification blocker -> blocking+ by triage.

Comment 7

[howie [:howie]]

Hi Hsin Yi, can you help to check if this is Gecko issue? Thanks.

Comment 8

[Ken Chang[:kenkai]]

It isn't the reference RIL. Ask help from CAF first.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to howie [:howie] from comment #7)
> Hi Hsin Yi, can you help to check if this is Gecko issue? Thanks.

I agree with Etienne that gaia relies on telephonyCall.emergency to indicate the emergency information correctly. We should start from gecko first.

In mozRIL, for every new call, we check "isEmergency" in [1] by reading the property "ril.ecclist" or "ro.ril.ecclist" [2]. 

So, here come more questions to the reporter:
1) It seems that you were using qcRIL because, according to the logs, there were messages with prefix "QCONTENT_HELPER". Is that right? 

2)  How is the test result on mozRIL? Could you please check if the properties, "ril.ecclist" and "ro.ril.ecclist", are correctly configured? Make sure you have the right emergency numbers listed. If it is reproducible on mozril, please provide us log with mozRIL debug messages by following the instruction [3]. Thank you.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyService.js?from=TelephonyService.js#1234 
[2] http://dxr.mozilla.org/mozilla-central/source/dom/telephony/gonk/TelephonyService.js?from=TelephonyService.js#390
[3] https://wiki.mozilla.org/B2G/QA/Tips_And_Tricks#Changing_preferences

Comment 10

[christopher.posselwhite]

1) The code passes through QCONTENT_HELPER, yes. We use the Qcom modem.
2) I am using the default prefs.js, which does not mention anything about ril.ecclist. I add the file as an attachment. How do I switch to mozRil? By running the Thundersoft phone? I could test that but it would have to be on 2.0 SW. When I try to reflash it to 2.1 according to https://developer.mozilla.org/en-US/Firefox_OS/Developer_phone_guide/Flame#Updating_your_Flame_to_a_nightly_build I can get the base SW in but when I tried to update to 2.1 if got stuck in boot-up. The Thundersoft phone has no reference to ril.ecclist in its preferences either, is there any point in running the test there then?

Comment 11

[christopher.posselwhite]

Attachment: Sony_prefs.js

Comment 12

[Anshul]

Reporter, please file an SR in QC case system so we can support you. Please also refrain from attaching QXDM logs to bugzilla bug as the tools to parse the logs are proprietary.

Comment 13

[christopher.posselwhite]

@Anshul: Read, but not understood unfortunately. Do you mean that
1) This is a QualComm bug and not a Mozilla one? What do you mean by SR?
2) You do not have access to the tools to read QXDM logs? If not, what harm does it do to provide as much information as possible for a bug?

Comment 14

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi all,
I reviewed the whole discussion thread again. Seems this doesn't depend on bug 1089447 while this one is talking about update on "emergency indication" and that is for update "number."

Based on this I am going to remove the dependency. Sorry for the confusion!

Comment 15

[bhavana bajaj [:bajaj]]

Marking this as POVB(part of vendor build) for now as this not look like a gecko/gaia issue(correct me if I understood something wrong here), :christopher, can you please follow up with CAF here?

Comment 16

[christopher.posselwhite]

I will file a support request with the vendor instead, yes.

Comment 17

[bhavana bajaj [:bajaj]]

(In reply to christopher.posselwhite from comment #16)
> I will file a support request with the vendor instead, yes.

I am removing the blocking-flag as there is not much to do here on our side.

Comment 18

[Anshul]

Fix provided to customer by QC.