1085313 - [Gaia] Refactor the error handler for icc.{set|unlock}CardLock API.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

In bug 1083745, we would like to deprecate IccCardLockError.lockType. But Gaia gets lockType from IccCardLockError now, like https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/simcard_dialog.js#L95-L128. 

let request = icc.unlockCardLock(lockType);
request.onerror = function(evt) {
  lockType = evt.target.error.lockType;
  ....
};

Actually the |evt.target.error.lockType| is just the same as the lockType passed by caller. We could simply rewrite the code as below,

let request = icc.unlockCardLock(lockType);
request.onerror = function(lockType, evt) {
  .....
}.bind(this, lockType);

Thank you.

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Edgar, what's the schedule for you to remove this lockType from Gecko ? I can take this first.

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

This bug blocks bug 1052825 which is a v2.2 P1 item for telephony team.
I can help to take cover this if you don't have free buffer to do this. :)
Thank you.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Sure Edgar,

based on our offline discussion, let me redirect this bug to you first. Thanks !

Comment 4

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: [mozilla-b2g:master] PR #25371

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8509155 [details] [review]
[mozilla-b2g:master] PR #25371

Hi EJ, may I have your review on Setting part?

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8509155 [details] [review]
[mozilla-b2g:master] PR #25371

Hi Alive, may I have your review on System part? Thank you

Comment 7

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8509155 [details] [review]
[mozilla-b2g:master] PR #25371

Hi sfoster, may I have your review for FTU part? Thank you.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8509155 [details] [review]
[mozilla-b2g:master] PR #25371

+system part

Comment 9

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8509155 [details] [review]
[mozilla-b2g:master] PR #25371

FTU part looks good to me. Looks like we have no test coverage for the retryCount property in the error in the FTU, I'm making a note to add that but its backfill and not necessary to land this.

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8509155 [details] [review]
[mozilla-b2g:master] PR #25371

r+ for settings part. Thanks Edgar !!

Comment 11

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Thanks to all of you for the review.

Comment 12

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

treeherder result looks good: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=db6d2c204673

Comment 13

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/bfbd561aff39154d65ef9891ce3f8bc9e9c5e44c