1085383 - [FM Radio] Failed assertion when seeking radio stations

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

An assertion fail when seeking for FM radio stations. Stack trace is shown below.

Hardware: flame-kk
Gecko: 211241:f2d7d694aae5

STR:

  - open FM radio App
  - tap 'Seek' button

Expected result

  - App searches for next radio station

Actual result

  - Failed assertion in Gecko

The stack trace is:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 206.1326]
0xb4623b9a in AssertMainThread () at ../../../mozilla-central/hal/Hal.cpp:78
78        MOZ_ASSERT(NS_IsMainThread());
(gdb) bt
#0  0xb4623b9a in AssertMainThread () at ../../../mozilla-central/hal/Hal.cpp:78
#1  mozilla::hal::(anonymous namespace)::AssertMainThread () at ../../../mozilla-central/hal/Hal.cpp:76
#2  0xb4624aaa in mozilla::hal::FMRadioSeek (aDirection=@0xac8b6edc: mozilla::hal::FM_RADIO_SEEK_DIRECTION_UP) at ../../../mozilla-central/hal/Hal.cpp:1075
#3  0xb4cb2174 in mozilla::dom::SeekRunnable::Run (this=<optimized out>) at ../../../../mozilla-central/dom/fmradio/FMRadioService.cpp:288
#4  0xb43085c4 in nsThread::ProcessNextEvent (this=0xadb6bfb0, aMayWait=<optimized out>, aResult=0xa91ffcf7)
    at ../../../../mozilla-central/xpcom/threads/nsThread.cpp:830
#5  0xb431cc40 in NS_ProcessNextEvent (aThread=0xadb6bfb0, aMayWait=aMayWait@entry=true)
    at /home/mozilla/Projects/mozilla/src/mozilla-central/xpcom/glue/nsThreadUtils.cpp:265
#6  0xb44d56a2 in mozilla::ipc::MessagePumpForNonMainThreads::Run (this=0xaa4b1430, aDelegate=0xa9e89080)
    at ../../../../mozilla-central/ipc/glue/MessagePump.cpp:368
#7  0xb44c3158 in MessageLoop::RunInternal (this=this@entry=0xa9e89080) at ../../../../mozilla-central/ipc/chromium/src/base/message_loop.cc:233
#8  0xb44c3172 in RunHandler (this=0xa9e89080) at ../../../../mozilla-central/ipc/chromium/src/base/message_loop.cc:226
#9  MessageLoop::Run (this=this@entry=0xa9e89080) at ../../../../mozilla-central/ipc/chromium/src/base/message_loop.cc:200
#10 0xb43096c8 in nsThread::ThreadFunc (aArg=0xadb6bfb0) at ../../../../mozilla-central/xpcom/threads/nsThread.cpp:350
#11 0xb697fca8 in _pt_root (arg=0xaa58ee80) at ../../../../../../mozilla-central/nsprpub/pr/src/pthreads/ptthread.c:212
#12 0xb6e5b22c in __thread_entry (func=0xb697fc01 <_pt_root>, arg=0xaa58ee80, tls=0xa91ffdd0) at bionic/libc/bionic/pthread_create.cpp:105
#13 0xb6e5b3c4 in pthread_create (thread_out=0xbef616b4, attr=<optimized out>, start_routine=0xb697fc01 <_pt_root>, arg=0x78)
    at bionic/libc/bionic/pthread_create.cpp:224
#14 0x00000000 in ?? ()

Comment 1

[Michael Wu [:mwu]]

Attachment: Allow FM radio tuning to be run on a separate thread

Bug 938809 allowed FMRadioSeek and SetFMRadioFrequency to be run off the main thread, but didn't actually remove the assertions that require them to be called on the main thread.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8520152 [details] [diff] [review]
Allow FM radio tuning to be run on a separate thread

Review of attachment 8520152 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d0f20c0182ae

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d0f20c0182ae