Closed Bug 1085403 Opened 10 years ago Closed 10 years ago

[Loop] Wrong outgoing call type (audio/video), calling from contact log, long press on one entry.

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: javier.deprado, Assigned: frsela)

References

Details

(Whiteboard: [Test-Run1][mobile app][not blocking][tef-triage][loop not in v1.1])

Attachments

(1 file)

Proposed patch
61 bytes, text/x-github-pull-request
jaoo
: review+
Details | Review 
ENV:
On flame (Gecko-b3429ef.Gaia-c6c6116) and fireE (firee-kk-v2.0-SW2E3-1)
Loop version: 1.1 , 2168965

STR(1):
1.- Set default call mode to VIDEO in loop settings.
2.- Select one call log with AUDIO icon.
3.- Long press on the entry, and select "call".
ACTUAL RESULT: Outgoing VIDEO call is made.

STR(2):
1.- Set default call mode to AUDIO in loop settings.
2.- Select one call log with VIDEO icon.
3.- Long press on the entry, and select "call".
ACTUAL RESULT: Outgoing AUDIO call is made

EXPECTED RESULT: Outgoing call type, should be of the call log type, instead of type set in settings.
Severity: normal → major
Whiteboard: [Test-Run1][mobile app] → [Test-Run1][mobile app][not blocking][tef-triage]
Assignee: nobody → frsela
Status: NEW → ASSIGNED
Attached file Proposed patch — 

        Attachment #8515972 -
        Flags: review?(josea.olivera)

        Attachment #8515972 -
        Flags: feedback?(oteo)

    
    

    
  
Comment on attachment 8515972 [details] [review]
Proposed patch

Removing the feedback request, with JA revision is enough.
I'll check the patch together with QA team when landing in master branch.
Thanks

        Attachment #8515972 -
        Flags: feedback?(oteo) → feedback-

        Attachment #8515972 -
        Flags: feedback-

    
    

    
  
Comment on attachment 8515972 [details] [review]
Proposed patch

LGTM. r=me

Thanks for taking care if it Fernando!

        Attachment #8515972 -
        Flags: review?(josea.olivera) → review+

    
    

    
  
Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/849ad223af9a731820960e3965693baff5d942f4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Test-Run1][mobile app][not blocking][tef-triage] → [Test-Run1][mobile app][not blocking][tef-triage][loop not in v1.1]

    
    

    
  
Tested on loop version 1.1: 38eadf0
Flame: flame-KK.user.v2.0.188based.B-65.Gecko-d44bb12.Gaia-dfdd626, 512mb
FireE: firee-kk-v2.0-SW2E5-4

It's still happening in both cases (STR(1) and STR(2))
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
It's working fine on master branch.  Loop version master: 30c29b
Pending to check on branch 1.1 when patch is merged on it.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

    
    

    
  
(In reply to Javier de Prado from comment #6)
> It's working fine on master branch.  Loop version master: 30c29b
> Pending to check on branch 1.1 when patch is merged on it.

Not a blocker issue for 1.1 release, so it will not be uplifted to that branch

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: