1085414 - Allow apps that are symbolically linked to be unit tested

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Anthony Ricaud (:rik)]

Context: I'm using the Gaia build system to run tests for a privileged app not part of Gaia. To do that, I create a symbolic link inside apps/ to my real app.

The build system currently only looks for real directories.

Comment 1

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/25336

Let me know if you need more details for this review.

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8507950 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25336

Do you know about outoftree_apps/ folder?
You can put any app here that will be shipped on device but ignored by git.

Comment 3

[Alexandre Poirot [:ochameau]]

Also, I don't see any try run on the PR, can you ensure having a green run before merging?

Comment 4

[Anthony Ricaud (:rik)]

I've pushed another time to get a Gaia try run.

Comment 5

[Anthony Ricaud (:rik)]

Got a green run :) https://github.com/mozilla-b2g/gaia/commit/c8b25a950f59dbe7cba8195305f3660369a3a3d7

Comment 6

[Anthony Ricaud (:rik)]

Comment on attachment 8507950 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25336

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: This is a test only change for BuddyUp. We'd like to test against 2.1.
[Testing completed]: Our automation did not crash in the last 24hours :)
[Risk to taking this patch] (and alternatives if risky): Limited to test runner.
[String changes made]: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/6e29339d3fd2158308784bec1e0c44f830ee77f1