Parent request summaries use 'Review' to incorrectly refer to a Review Request

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: smacleod, Assigned: smacleod)

Tracking

Development/Staging

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
When pushing the summary generated for the parent review request is of the form 'Review for review ID: <review-id>', which incorrectly uses 'Review' when referring to a Review Request.

We should make sure this is changed before launching (Along with any other terminology inconsistencies).

I think it would be fine to quickly change things to have the parent's summary be just '<review-id>'. This would make the bugzilla attachment be just <review-id> so maybe we should decouple that.
(Assignee)

Comment 1

4 years ago
Created attachment 8507966 [details]
Review for review ID: bz://1085417/smacleod
(Assignee)

Comment 2

4 years ago
/r/229 - Bug 1085417 - Stop using 'Review' in RB summaries.

Pull down this commit:

hg pull review -r 1e40a5738920ed36c043aaa94a19dbd1f283ffe8
(Assignee)

Updated

4 years ago
Attachment #8507966 - Flags: review?(mcote)

Updated

4 years ago
Attachment #8507966 - Flags: review+
(Assignee)

Updated

4 years ago
Attachment #8507966 - Flags: review?(mcote)
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/e0539992d9c7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.