Implement new design for Loop's green call buttons

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
Client
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: shell, Assigned: jaws)

Tracking

unspecified
mozilla36
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox34+ fixed, firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
see bug 1079905 for the design decisions on color and making the button corners like the rest (just barely rounded).  We know at least 4 places this needs to be updated.  Darrin has 3 here https://bug1079905.bugzilla.mozilla.org/attachment.cgi?id=8501777 and there's at least 1-2 on the stand-alone of the same "start" and "answer" buttons.  see the bottom 2 options here for visualization
http://cl.ly/image/351M2k0o370o
(Reporter)

Updated

4 years ago
backlog: --- → Fx34+
(Reporter)

Updated

4 years ago
Blocks: 1050307
[Tracking Requested - why for this release]:
We're advised that we need to make this change for the Fx34 release.
Assignee: nobody → jaws
tracking-firefox34: --- → ?
Status: NEW → ASSIGNED
Iteration: --- → 36.1
Points: --- → 2
Flags: qe-verify-
Flags: firefox-backlog+
Hardware: x86 → All
From bug 1079905 comment 8,
> Ok, so going with replacing all green buttons in the Hello UI with Summit Teal vibrant (#5BC0A4) and 
> white foreground (text + icons). Also shifting the pill button in the contacts UI to a shorter, 
> rounded rect, in line with our other Hello buttons (see bug 1075203). Thanks everyone!

Darrin, what should the hover and hover:active colors be?
Flags: needinfo?(dhenein)
As well as the border-color.
While working on this, I noticed that all buttons in Loop get darker in :hover and :hover:active, but the call-details button actually gets brighter on :hover and is lacking a :hover:active color.
From shorlander over IRC:
<shorlander> jaws: hover = 47b396 hover:active = 3aa689
Flags: needinfo?(dhenein)
Created attachment 8508317 [details] [diff] [review]
Patch
Attachment #8508317 - Flags: review?(gijskruitbosch+bugs)
Created attachment 8508324 [details] [diff] [review]
Patch v1.1

With Call Details button now having border-radius:2px instead of the 30px.
Attachment #8508317 - Attachment is obsolete: true
Attachment #8508317 - Flags: review?(gijskruitbosch+bugs)
Attachment #8508324 - Flags: review?(gijskruitbosch+bugs)

Comment 8

4 years ago
Comment on attachment 8508324 [details] [diff] [review]
Patch v1.1

Review of attachment 8508324 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, make sure you deal with the foreground color (also for icons!) somewhere else.

::: browser/components/loop/content/shared/css/common.css
@@ +121,5 @@
>    .btn-accept:hover,
>    .btn-success:hover,
>    .btn-accept + .btn-chevron:hover {
> +    background-color: #47b396;
> +    border: 1px solid #47b396;

Nit: Here and below, just use border-color: #47b396.
Attachment #8508324 - Flags: review?(gijskruitbosch+bugs) → review+
status-firefox34: --- → affected
tracking-firefox34: ? → +
https://hg.mozilla.org/mozilla-central/rev/819ec23d4ad1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla35
(In reply to Carsten Book [:Tomcat] from comment #10)
> https://hg.mozilla.org/mozilla-central/rev/819ec23d4ad1

Should this not be milestone=mozilla36? mozilla-central is Firefox 36 currently.
status-firefox35: --- → affected
status-firefox36: --- → fixed
Target Milestone: mozilla35 → mozilla36
Yes, it should be Target Milestone=mozilla36. Thank you for catching this.
Hi Pauly -- Can you verify this in tomorrow's Nightly?
Flags: needinfo?(paul.silaghi)
This looks like some pretty simple style changes (mostly colour changes). Do you see any reason not to uplift to Beta and Aurora immediately?
Flags: needinfo?(jaws)
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #13)
> Hi Pauly -- Can you verify this in tomorrow's Nightly?

We've got more important bugs to test than visual design changes. This can uplift without QA testing in my opinion.
Flags: needinfo?(paul.silaghi)
(In reply to Lawrence Mandel [:lmandel] from comment #14)
> This looks like some pretty simple style changes (mostly colour changes). Do
> you see any reason not to uplift to Beta and Aurora immediately?

This can uplift immediately.
Flags: needinfo?(jaws)
Comment on attachment 8508324 [details] [diff] [review]
Patch v1.1

Approval Request Comment
[Feature/regressing bug #]: Loop changes for Firefox 34
[User impact if declined]: This is a style change for the call buttons.
[Describe test coverage new/current, TBPL]: Style change only. No automated tests. Will manually verify.
[Risks and why]: Low risk associated with style change. This is primarily a patch that changes colours.
[String/UUID change made/needed]: No.
Attachment #8508324 - Flags: approval-mozilla-beta+
Attachment #8508324 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.