1085568 - nsIdleService should write Android logs as "GeckoIdleService", not "IdleService"

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Richard Newman [:rnewman]]

After Bug 834327 this doesn't even affect gonk, so I see no reason not to do this.

Comment 1

[Richard Newman [:rnewman]]

Attachment: nsIdleService should write Android logs as "GeckoIdleService", not "IdleService", and at DEBUG. v1

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 8508149 [details] [diff] [review]
nsIdleService should write Android logs as "GeckoIdleService", not "IdleService", and at DEBUG. v1

r+ since this code was already here, but it seems really wonky to have every logging thing duplicated in the file, once with PR_LOG and once with android.  Seems like it would be much better to have something like:

#ifndef MOZ_WIDGET_ANDROID
#define IDLE_DEBUG_LOG(...) \
do { \
  PR_LOG(sLog, PR_LOG_DEBUG, (__VA_ARGS__)); \
} while (0)
#else
#define IDLE_DEBUG_LOG(...) \
do { \
  PR_LOG(sLog, PR_LOG_DEBUG, (__VA_ARGS__)); \
  __android_log_print(LOG_LEVEL, LOG_TAG, __VA_ARGS__); \
} while (0)
#endif

and then just use IDLE_DEBUG_LOG instead of PR_LOG, and nuke all the MOZ_WIDGET_ANDROID portions. (Whether we want both PR_LOG and __android_log_print on android is debatable; this just mimics current behaviour.)

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/4abc7b1445aa

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4abc7b1445aa