Closed Bug 1085568 Opened 5 years ago Closed 5 years ago

nsIdleService should write Android logs as "GeckoIdleService", not "IdleService"

Categories

(Core :: Widget: Android, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: rnewman, Assigned: rnewman)

Details

Attachments

(1 file)

After Bug 834327 this doesn't even affect gonk, so I see no reason not to do this.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
OS: Mac OS X → Android
Hardware: x86 → All
Version: 33 Branch → Trunk
Comment on attachment 8508149 [details] [diff] [review]
nsIdleService should write Android logs as "GeckoIdleService", not "IdleService", and at DEBUG. v1

r+ since this code was already here, but it seems really wonky to have every logging thing duplicated in the file, once with PR_LOG and once with android.  Seems like it would be much better to have something like:

#ifndef MOZ_WIDGET_ANDROID
#define IDLE_DEBUG_LOG(...) \
do { \
  PR_LOG(sLog, PR_LOG_DEBUG, (__VA_ARGS__)); \
} while (0)
#else
#define IDLE_DEBUG_LOG(...) \
do { \
  PR_LOG(sLog, PR_LOG_DEBUG, (__VA_ARGS__)); \
  __android_log_print(LOG_LEVEL, LOG_TAG, __VA_ARGS__); \
} while (0)
#endif

and then just use IDLE_DEBUG_LOG instead of PR_LOG, and nuke all the MOZ_WIDGET_ANDROID portions. (Whether we want both PR_LOG and __android_log_print on android is debatable; this just mimics current behaviour.)
Attachment #8508149 - Flags: review?(vladimir) → review+
https://hg.mozilla.org/mozilla-central/rev/4abc7b1445aa
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.