1085576 - "Mark As Solved" causes "Oh, no! It looks like an unexpected error occurred"

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P3)

Description

[FredMcD]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141011015303

Steps to reproduce:

As the poster of a question, i received a message that there was a response to my
question. I had pressed the "Mark As Solved" button.



Actual results:

 I was redirected to the "Oh, no! It looks like an unexpected error occurred" page.
Note: I had already flagged one of the responses as Solved.



Expected results:

Related: Bug 1018168 - Reply button on contributors e-mail go to wrong response when clicked

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Possibly this is an issue when you click the solve button from an email for a question already marked solved?

Comment 2

[FredMcD]

> Actual results:
> 
> Note: I had already flagged one of the responses as Solved.

Comment 3

[Michael Cooper [:mythmon]]

It seems like marking a question as solved after it has already been solved is the problem. I see errors related to that in Sentry: https://errormill.mozilla.org/support/support/group/173065/

I think on the website we hide the mark as solved UI after there is a solution. Clearly we can't do this in emails. We should be more robust here.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Actually, I work on this today. Should be easyish.

Comment 5

[FredMcD]

While you are at it, can you do something about Bug 1018168 ?
All you have to do is remove the Solved button from the e-mail.
There are many, many that press the Solved by accident.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/2176

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/445894e3b046e38a6945bf974dd7270893bf283f

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.