Closed
Bug 1085631
Opened 8 years ago
Closed 8 years ago
gecko build: Flame-KK Opt
Categories
(Taskcluster :: General, defect, P1)
Taskcluster
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlal, Assigned: wcosta)
References
Details
Attachments
(4 files, 1 obsolete file)
39 bytes,
text/x-review-board-request
|
jlal
:
review+
garndt
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
garndt
:
review+
jlal
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
jlal
:
review+
garndt
:
review+
|
Details |
39 bytes,
text/x-review-board-request
|
jlal
:
review+
garndt
:
review+
|
Details |
No description provided.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Reporter | ||
Comment 1•8 years ago
|
||
I wanted to add a few notes here (I am pretty sure you know most of this already) - you need bits off a flame device to actually build a flame (meta right) - we must not distribute the builds we generate here (we cannot use public/ artifacts for the builds) - we should use separate build images (probably based off the current ones) which should be private and contain the bits we are not allowed to distribute. (lets catch up today to chat about this in more detail)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8531446 -
Flags: review?(jlal)
Assignee | ||
Comment 3•8 years ago
|
||
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target. /r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script. /r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image. /r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task. Pull down these commits: hg pull review -r 9e521fe8d711ccdb63ae1a2d4a7c95ac4f1992bf
Assignee | ||
Updated•8 years ago
|
Attachment #8531446 -
Flags: review?(garndt)
Assignee | ||
Comment 4•8 years ago
|
||
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target. /r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script. /r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image. /r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task. Pull down these commits: hg pull review -r 9e521fe8d711ccdb63ae1a2d4a7c95ac4f1992bf
Comment 5•8 years ago
|
||
Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta
Looks good, there's just some overlap with the job tasks file changes made for additional parameters that jlal is working on.
Attachment #8531446 -
Flags: review?(garndt) → review+
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Greg Arndt [:garndt] from comment #5) > Comment on attachment 8531446 [details] > MozReview Request: bz://1085631/wcosta > > Looks good, there's just some overlap with the job tasks file changes made > for additional parameters that jlal is working on. You mean in the decision patches, right?
Flags: needinfo?(garndt)
Comment 7•8 years ago
|
||
removing ni, spoke about it in person. Should incorporate the work done in the decision task.
Flags: needinfo?(garndt)
Assignee | ||
Comment 8•8 years ago
|
||
The patches were re-factored on top of Bug 1105439 patches. Once Bug 1105439 lands, I push these new patches to review board. https://github.com/walac/gecko-dev/tree/bugz/1085631
Depends on: 1105439
Assignee | ||
Comment 9•8 years ago
|
||
Ok, I pushed the new patches on top on Bug 1105439. Could you guys take a look at them again?
Reporter | ||
Comment 10•8 years ago
|
||
Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta
Is the reviewboard push the right set of commits? These seem to be based on pre-inheritance tasks?
Attachment #8531446 -
Flags: review?(jlal)
Assignee | ||
Updated•8 years ago
|
Attachment #8531446 -
Flags: review?(jlal)
Attachment #8531446 -
Flags: review?(garndt)
Attachment #8531446 -
Flags: review+
Assignee | ||
Comment 11•8 years ago
|
||
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target. /r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script. /r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image. /r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task. Pull down these commits: hg pull review -r 14653dd39edefff8ae2c1b75237ccd4c37ece90c
Assignee | ||
Comment 12•8 years ago
|
||
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target. /r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script. /r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image. /r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task. Pull down these commits: hg pull review -r 14653dd39edefff8ae2c1b75237ccd4c37ece90c
Assignee | ||
Comment 13•8 years ago
|
||
(In reply to James Lal [:lightsofapollo] from comment #10) > Comment on attachment 8531446 [details] > MozReview Request: bz://1085631/wcosta > > Is the reviewboard push the right set of commits? These seem to be based on > pre-inheritance tasks? Ops, sorry, I forgot to publish the changes.
Assignee | ||
Comment 14•8 years ago
|
||
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target. /r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script. /r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image. /r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task. Pull down these commits: hg pull review -r 5148fe501609cc6d0989ee599a0e6acfb4a0b981
Reporter | ||
Comment 15•8 years ago
|
||
Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta
lgtm
Attachment #8531446 -
Flags: review?(jlal) → review+
Updated•8 years ago
|
Attachment #8531446 -
Flags: review?(garndt) → review+
Assignee | ||
Comment 16•8 years ago
|
||
http://reviewboard-hg.mozilla.org/gecko/rev/5148fe501609
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•8 years ago
|
||
https://hg.mozilla.org/projects/alder/rev/044cd60519b6
Comment 18•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6a6ff39d1a74 https://hg.mozilla.org/mozilla-central/rev/d4c985c6f85e https://hg.mozilla.org/mozilla-central/rev/7bf177955351 https://hg.mozilla.org/mozilla-central/rev/7e9b3d5d3c2f
Assignee | ||
Comment 19•7 years ago
|
||
Attachment #8531446 -
Attachment is obsolete: true
Attachment #8618419 -
Flags: review+
Attachment #8618420 -
Flags: review+
Attachment #8618421 -
Flags: review+
Attachment #8618422 -
Flags: review+
Assignee | ||
Comment 20•7 years ago
|
||
Assignee | ||
Comment 21•7 years ago
|
||
Assignee | ||
Comment 22•7 years ago
|
||
Assignee | ||
Comment 23•7 years ago
|
||
Updated•7 years ago
|
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: --- → mozilla41
Version: unspecified → Trunk
Comment 24•7 years ago
|
||
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•