1085631 - gecko build: Flame-KK Opt

Status: RESOLVED FIXED

(Taskcluster :: General, defect, P1)

Comment 1

[James Lal [:lightsofapollo]]

I wanted to add a few notes here (I am pretty sure you know most of this already)

 - you need bits off a flame device to actually build a flame (meta right)
 - we must not distribute the builds we generate here (we cannot use public/ artifacts for the builds)
 - we should use separate build images (probably based off the current ones) which should be private and contain the bits we are not allowed to distribute.

(lets catch up today to chat about this in more detail)

Comment 2

[Wander Lairson Costa]

Attachment: MozReview Request: bz://1085631/wcosta

Comment 3

[Wander Lairson Costa]

/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 9e521fe8d711ccdb63ae1a2d4a7c95ac4f1992bf

Comment 4

[Wander Lairson Costa]

/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 9e521fe8d711ccdb63ae1a2d4a7c95ac4f1992bf

Comment 5

[Greg Arndt [:garndt]]

Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta

Looks good, there's just some overlap with the job tasks file changes made for additional parameters that jlal is working on.

Comment 6

[Wander Lairson Costa]

(In reply to Greg Arndt [:garndt] from comment #5)
> Comment on attachment 8531446 [details]
> MozReview Request: bz://1085631/wcosta
> 
> Looks good, there's just some overlap with the job tasks file changes made
> for additional parameters that jlal is working on.

You mean in the decision patches, right?

Comment 7

[Greg Arndt [:garndt]]

removing ni, spoke about it in person.  Should incorporate the work done in the decision task.

Comment 8

[Wander Lairson Costa]

The patches were re-factored on top of Bug 1105439 patches. Once Bug 1105439 lands, I push these new patches to review board.

https://github.com/walac/gecko-dev/tree/bugz/1085631

Comment 9

[Wander Lairson Costa]

Ok, I pushed the new patches on top on Bug 1105439. Could you guys take a look at them again?

Comment 10

[James Lal [:lightsofapollo]]

Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta

Is the reviewboard push the right set of commits? These seem to be based on pre-inheritance tasks?

Comment 11

[Wander Lairson Costa]

/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 14653dd39edefff8ae2c1b75237ccd4c37ece90c

Comment 12

[Wander Lairson Costa]

/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 14653dd39edefff8ae2c1b75237ccd4c37ece90c

Comment 13

[Wander Lairson Costa]

(In reply to James Lal [:lightsofapollo] from comment #10)
> Comment on attachment 8531446 [details]
> MozReview Request: bz://1085631/wcosta
> 
> Is the reviewboard push the right set of commits? These seem to be based on
> pre-inheritance tasks?

Ops, sorry, I forgot to publish the changes.

Comment 14

[Wander Lairson Costa]

/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 5148fe501609cc6d0989ee599a0e6acfb4a0b981

Comment 15

[James Lal [:lightsofapollo]]

Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta

lgtm

Comment 16

[Wander Lairson Costa]

http://reviewboard-hg.mozilla.org/gecko/rev/5148fe501609

Comment 17

[James Lal [:lightsofapollo]]

https://hg.mozilla.org/projects/alder/rev/044cd60519b6

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a6ff39d1a74
https://hg.mozilla.org/mozilla-central/rev/d4c985c6f85e
https://hg.mozilla.org/mozilla-central/rev/7bf177955351
https://hg.mozilla.org/mozilla-central/rev/7e9b3d5d3c2f

Comment 20

[Wander Lairson Costa]

Attachment: MozReview Request: [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.

Comment 21

[Wander Lairson Costa]

Attachment: MozReview Request: [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Comment 22

[Wander Lairson Costa]

Attachment: MozReview Request: [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.

Comment 23

[Wander Lairson Costa]

Attachment: MozReview Request: [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.

Comment 24

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...