Closed Bug 1085631 Opened 7 years ago Closed 7 years ago

gecko build: Flame-KK Opt

Categories

(Taskcluster :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlal, Assigned: wcosta)

References

Details

Attachments

(4 files, 1 obsolete file)

No description provided.
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
I wanted to add a few notes here (I am pretty sure you know most of this already)

 - you need bits off a flame device to actually build a flame (meta right)
 - we must not distribute the builds we generate here (we cannot use public/ artifacts for the builds)
 - we should use separate build images (probably based off the current ones) which should be private and contain the bits we are not allowed to distribute.

(lets catch up today to chat about this in more detail)
Attached file MozReview Request: bz://1085631/wcosta (obsolete) —
Attachment #8531446 - Flags: review?(jlal)
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 9e521fe8d711ccdb63ae1a2d4a7c95ac4f1992bf
Attachment #8531446 - Flags: review?(garndt)
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 9e521fe8d711ccdb63ae1a2d4a7c95ac4f1992bf
Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta

Looks good, there's just some overlap with the job tasks file changes made for additional parameters that jlal is working on.
Attachment #8531446 - Flags: review?(garndt) → review+
(In reply to Greg Arndt [:garndt] from comment #5)
> Comment on attachment 8531446 [details]
> MozReview Request: bz://1085631/wcosta
> 
> Looks good, there's just some overlap with the job tasks file changes made
> for additional parameters that jlal is working on.

You mean in the decision patches, right?
Flags: needinfo?(garndt)
removing ni, spoke about it in person.  Should incorporate the work done in the decision task.
Flags: needinfo?(garndt)
The patches were re-factored on top of Bug 1105439 patches. Once Bug 1105439 lands, I push these new patches to review board.

https://github.com/walac/gecko-dev/tree/bugz/1085631
Depends on: 1105439
Blocks: 1098467
Ok, I pushed the new patches on top on Bug 1105439. Could you guys take a look at them again?
Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta

Is the reviewboard push the right set of commits? These seem to be based on pre-inheritance tasks?
Attachment #8531446 - Flags: review?(jlal)
Attachment #8531446 - Flags: review?(jlal)
Attachment #8531446 - Flags: review?(garndt)
Attachment #8531446 - Flags: review+
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 14653dd39edefff8ae2c1b75237ccd4c37ece90c
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 14653dd39edefff8ae2c1b75237ccd4c37ece90c
(In reply to James Lal [:lightsofapollo] from comment #10)
> Comment on attachment 8531446 [details]
> MozReview Request: bz://1085631/wcosta
> 
> Is the reviewboard push the right set of commits? These seem to be based on
> pre-inheritance tasks?

Ops, sorry, I forgot to publish the changes.
/r/1125 - [PATCH 1/4] Bug 1085631 part1: Replace b2g-config by target.
/r/1127 - [PATCH 2/4] Bug 1085631 part2: Allow the use of a custom build script.
/r/1129 - [PATCH 3/4] Bug 1085631 part3: Add phone builder docker image.
/r/1131 - [PATCH 4/4] Bug 1085631 part4: Add the phone build task.

Pull down these commits:

hg pull review -r 5148fe501609cc6d0989ee599a0e6acfb4a0b981
Comment on attachment 8531446 [details]
MozReview Request: bz://1085631/wcosta

lgtm
Attachment #8531446 - Flags: review?(jlal) → review+
Attachment #8531446 - Flags: review?(garndt) → review+
http://reviewboard-hg.mozilla.org/gecko/rev/5148fe501609
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #8531446 - Attachment is obsolete: true
Attachment #8618419 - Flags: review+
Attachment #8618420 - Flags: review+
Attachment #8618421 - Flags: review+
Attachment #8618422 - Flags: review+
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: --- → mozilla41
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.