1085651 - Incorrect time (clock) and status showed in the statusbar

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Christophe GÉRARDIN]

Attachment: Screenshot of the lockscreen

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141013200324

Steps to reproduce:

Flash to latest 2.2 and boot the phone.


Actual results:

Time and 3G / Wifi status on the statusbar is incorrect when an application is on the foreground or the screen is locked (time showed on the lockscreen is ok)


Expected results:

Correct time and connection status showed on the statusbar.

Comment 1

[Christophe GÉRARDIN]

Phone used : ZTE Open C (france)

Comment 2

[YF (Yang)]

dupe of bug 1061797?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think I just started seeing this as well, and it's different from bug 1061797.

The clock in the status bar is wrong at the lockscreen or when in an app, but it's fine when I'm at the homescreen.  Is that what you're seeing as well?


The odd thing is that I started seeing it noticeably after the bug was filed -- I didn't have problems in gaia 6a7fb482a03c5083ef79b41e7b0dfab27527cd04 from Monday, but I do see it with gaia 3c1668ad793d4f1a40831c46638acef38e0db230 from Friday.  So the trigger of the bug might not be something purely in the build...

Comment 4

[Martin Creutziger [:MMx]]

I can also confirm this, and yes it is not bug 1061797:
 
On the homescreen, the status is current.
When an app ist in the foreground, the status is what *was* current at the time when any app was first launched after reboot.
The old status is identical for *all* apps, no matter whether it is freshly started or not.

e.g.: current is: no WiFi, time "23:56", in an app, the WiFi signal is still shown and time is 21:32. Which I remember is around the time when I first launched the first app after booting the phone.

Very interesting "feature": when I pull down the status menu, the current info "blends" over the old info, making it completely unreadable.

configuration here:
Flame running latest-central build-ID 20141230010205

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

I've seen this too so I'm confirming it. AFAIK the statusbar is handled by the system app, not the homescreen so I think it would be best to move this bug in the system component.

Comment 6

[Gregor Wagner [:gwagner]]

qaurgent since its on 2.2.
Can QA confirm?

Comment 7

[Sam Foster [:sfoster] (he/him)]

I have seen the statusbar in both the SMS and Email app display the wrong time - it seems to be the time at which that app was launched. I imagine it affects all foreground app, but those 2 are most likely to be long-running.

Comment 9

[Pi Wei Cheng [:piwei] (inactive)]

I cannot reproduce this bug on latest Flame 2.2. I was able to reproduce bug 1061797 (it shows wrong time on lockscreen after reboot), but not this bug. Status bar shows correct time while in an app.

This bug reminds me of bug 1154635 where it has been fixed by Bug 1154800.

Reporter please test on latest and see if it still occurs.

Device: Flame 2.2 (319MB, full flashed, KK)
BuildID: 20150604002503
Gaia: b96e657ce2822df5da5da1a8ba91c38ad3281bc9
Gecko: 273f8ee45c88
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Leaving qawanted for others to attempt.

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I also did not reproduce this issue after 10 flashes to today's Flame 2.2 Nightly build.

Actual Results: Time and status bar showed the same information both in and out of apps.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150604002503
Gaia: b96e657ce2822df5da5da1a8ba91c38ad3281bc9
Gecko: 273f8ee45c88
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 11

[Brogan Zumwalt [Inactive]]

This issue DOES reproduce on the latest Flame 2.2

Differe

Device: Flame 2.2
Build ID: 20150610002502
Gaia: 06edb0f8db7c2f45cde54401a8593663059861a4
Gecko: a3d7b08fb0ec
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 12

[Brogan Zumwalt [Inactive]]

Issue DOES reproduce on the latest Flame 2.2

Comparing status bar time between Homescreen and open app shows difference of up to 3 minutes between the two times. Homescreen time is correct, open app shows either a few minutes fast or a few minutes slow (both observed in multiple apps.)

Noticed that just before completing FTU after flashing, there was a split second where the status bar time read an hour fast before correcting itself on homescreen.

Link to video of time difference switching between homescreen and cost control app: http://youtu.be/PY9YxBsvX1I


Device: Flame 2.2
Build ID: 20150610002502
Gaia: 06edb0f8db7c2f45cde54401a8593663059861a4
Gecko: a3d7b08fb0ec
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 13

[Michael Henretty [:mikehenrty][:mhenretty]]

Guillaume, can you take a look here?

Comment 14

[Guillaume Marty [:gmarty]]

I found a STR for this bug that does NOT reproduce on master:
1. Start to open the utility tray
2. Lock the screen with the utility tray being opened mid-way (keep your finger on the screen while locking)
3. Unlock the screen

The status bar when minimised won't update its time until the utility tray is opened and closed again, it will then work as expected.

Comment 15

[Guillaume Marty [:gmarty]]

Attachment: Github PR

Etienne, can you review this patch please? I added unit tests to cover the STR described above.

Comment 16

[Etienne Segonzac (:etienne)]

Comment on attachment 8622512 [details] [review]
Github PR

small comment about the test, but r=me with that!

Comment 17

[Guillaume Marty [:gmarty]]

Landed in master in https://github.com/mozilla-b2g/gaia/commit/c4d3b8fd78bcd7eff1b127060ec6490a891b7a35

Comment 18

[Guillaume Marty [:gmarty]]

Comment on attachment 8622512 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Status bar
[User impact] if declined: The time shown by the status bar may be different depending on its state after a bit of fiddling with the utility tray.
[Testing completed]: This patch is very minimal but completely unit tested. There is a STR above that can be used for manual testing.
[Risk to taking this patch] (and alternatives if risky): Very low for the reason mentioned just above.
[String changes made]: None.

Comment 19

[Josh Cheng [:josh]]

Comment on attachment 8622512 [details] [review]
Github PR

Approving as this improves user experience.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.2 uplift.

Comment 21

[Guillaume Marty [:gmarty]]

Here's a patch for v2.2:
https://github.com/mozilla-b2g/gaia/pull/30718

Comment 22

[Ryan VanderMeulen [:RyanVM]]

The PR has a Linter failure.
https://s3-us-west-2.amazonaws.com/taskcluster-public-artifacts/VHC7ISEPQ6-mjuEmPjCHlw/0/public/logs/live_backing.log

Comment 23

[Guillaume Marty [:gmarty]]

It's all green now :-)

Comment 24

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/b39d4f5b4937592ded19ec65e113a74177ae1f86

Comment 25

[Pi Wei Cheng [:piwei] (inactive)]

Flashed to the same build used on comment 12 and I still couldn't reproduce the problem. However using the str provided at comment 14 I WAS able to reproduce the bug. I doubt that Brogan tried with this STR when he reproduced it so I dug deeper.

It has to do with having some apps opened in the background, return to homescreen, lock the phone and unlock it, a minute or two has passed, and then re-open the apps that were opened before. Highly likely that I at comment 9 didn't try this (locking/unlocking the phone with apps in background) that's why I wasn't seeing it.

This issue is verified as fixed on Flame and Aries. Status bar time remains consistent and correct after locking and unlocking the phone with app opened in the background.

Verified on:
Device: Flame 2.6
BuildID: 20151209030343
Gaia: 961528f4391668bc89ec0be14fa367cea099b588
Gecko: 319be5e7ce3061c7c16f24d750b6dacdbcac4c35
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Aries 2.6
BuildID: 20151209121803
Gaia: 961528f4391668bc89ec0be14fa367cea099b588
Gecko: 319be5e7ce3061c7c16f24d750b6dacdbcac4c35
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Flame 2.5
BuildID: 20151208120554
Gaia: 2d54c29f429bed790b5d8284633812dc2b782518
Gecko: ff31a251b2f6149edf4fc0a199133ef2e190ceac
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Device: Flame 2.2
BuildID: 20151209032501
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: 4381c4b69b9c
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0