1085660 - Dashboard numbers without deltas

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screenshot 2014-10-20 14.26.27.png

The management Dashboard shows the numbers for various things for various "time slots". That's great. 
But what it also does is showing the delta. E.g. the difference between number of new users today compared to yesterday. This is not good. 

It's not good because it's never a fair comparison to compare "this week" with "last week" if "this week" hasn't fully finished yet. It makes "this week" look bad. 

Instead of the deltas, replace them with last time slot's number. The screenshot, look at "This week" for "New Events". It says "8 (-13)" (where the bracket means smaller font). That means, 8 new events this week and 21 last week. Thus, what it should say is "8 (21)".

Comment 1

[Peter Bengtsson [:peterbe]]

I think the server-side code does something like this::

    counts['today'] = qs.filter(**make_filter(gte=today)).count()
    counts['today_delta'] = (
        counts['today'] -
        qs.filter(**make_filter(gte=yesterday, lt=today)).count()
    )

Instead it could do this::

    counts['today'] = qs.filter(**make_filter(gte=today)).count()
    counts['yesterday'] = qs.filter(**make_filter(gte=yesterday, lt=today)).count()

And the angularjs template would need to be updated accordingly.

Comment 2

[Peter Bengtsson [:peterbe]]

Note, a lot of code was added to make it possible to set css classes called "negative" and "positive". Those would need to be deleted from the angular app and from the CSS.

Comment 3

[Lisa Hewus Fresh [:lfresh]]

Submitted PR https://github.com/mozilla/airmozilla/pull/109

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/945ad795b659893ad9dd1648e7ac69220c2540ff
Fixes bug 1085660 - Show prior count instead of delta

https://github.com/mozilla/airmozilla/commit/3be7fb4ef589d89040229f2063b1c7a3cab6adbf
Merge pull request #109 from bugzPDX/1085660_bug

Fixes bug 1085660