1085676 - Cannot add report for today due to timezone issue

Status: RESOLVED WONTFIX

(Mozilla Reps Graveyard :: reps.mozilla.org, defect, P4)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

When I try to submit a report for today, I get the following error message:

  "Report date cannot be in the future."

I can only assume this is due to "the future" being calculated on the server, using the server's timezone. I'm in New Zealand (GMT+13) - so while it may seem like I'm from the future, it is indeed possible for me to accomplish things during what appears to be tomorrow but is in fact today for me.

Comment 1

[Balaji]

I would like to work on this bug and wanna know where this occurs ?

Comment 2

[Michael Kohler [:mkohler]]

This happens when creating a new report (https://reps.mozilla.org/reports/new/) and the timezone is far enough to be a date in the future in the view of a server.

Example:
UTC is 9pm, Japan is already at 6am the next day though. This means the server expects "February 12th" as a date, but the local user time is already "February 13th" and therefore validation fails.

Do you see what I mean?

Comment 3

[Balaji]

(In reply to Michael Kohler [:mkohler] from comment #2)
> This happens when creating a new report
> (https://reps.mozilla.org/reports/new/) and the timezone is far enough to be
> a date in the future in the view of a server.
> 
> Example:
> UTC is 9pm, Japan is already at 6am the next day though. This means the
> server expects "February 12th" as a date, but the local user time is already
> "February 13th" and therefore validation fails.
> 
> Do you see what I mean?

I got what you are saying.  so do i need to login as an admin to create a report?

Comment 4

[Michael Kohler [:mkohler]]

(In reply to Balaji from comment #3)
> I got what you are saying.  so do i need to login as an admin to create a
> report?

No, every Rep can file a report: https://reps.mozilla.org/reports/new/

But yes, you need to go through /admin to log in to the portal. Probably best to create a new user through the Django admin interface and mark it as "staff" so login work.

Comment 5

[Balaji]

I have got the issue . I have few suggestions 
  1. is possible to get user's timezone from request or frontend?. Then we can get the time of their timezone and compare the date in backend .
  2. if there is no way to get user's timezone , then we need to think of allowing one day greater than today or someother way to achieve this comparison?

Comment 6

[Michael Kohler [:mkohler]]

The timezone is on the user's profile, but I'm not sure if we can assume that the user always is in that timezone. Another idea would be to get the timezone from the location the user selects while doing the report, but we would need some kind of lookup mechanism for that.

I think I'd be okay with allowing reports generally that are one day in the future from the server's point of view.

Daniele, what do you think?

Comment 7

[Daniele "Mte90" Scasciafratte]

As I can see with JavaScript is possible get the timezone with `Intl.DateTimeFormat().resolvedOptions().timeZone` (tried right now in my browser console just to be sure). This API is supported by a lot of browsers https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat and with that later is possible to count the right time.
From the Django side seems that this framework support only the datetime picker to use later so if we want to use the timezone in the moment of visiting the page (that can be different from the configured one) JavaScript is the only way.

Comment 8

[Balaji]

Even though we get timezone info from frontend , when comparing date in backend we need to get that user's timezone's time and validate.

Comment 9

[Daniele "Mte90" Scasciafratte]

I think that from the frontend we can send the timezone when the user publish a report so the backend has this value during the evaluation.

Comment 10

[Balaji]

Fine. I will make the changes in both frontend and bakend also. Thanks for the info @Daniele and @Michael.

Comment 11

[Balaji]

Hi ,
  I have made a pull request .
https://github.com/mozilla/remo/pull/1439

Comment 12

[Michael Kohler [:mkohler]]

As we've moved from reps.mozilla.org to the Community Portal, I'm closing this bug. Filter out these emails by searching for "REPS_PORTAL_BUG_CLOSURE"