1085719 - bzpost should link to Treeherder instead of TBPL

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzpost, defect)

Description

[Ed Morley [:emorley]]

https://hg.mozilla.org/hgcustom/version-control-tools/file/66ec32ebac13/hgext/bzpost/__init__.py#l94
https://hg.mozilla.org/hgcustom/version-control-tools/file/66ec32ebac13/hgext/bzpost/__init__.py#l149

Note the repo names are different to TBPL - they actually match the buildbot 'branch' (and repo directory name) now. See the "name" property in:
https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/fixtures/repository.json

Comment 1

[Ed Morley [:emorley]]

Attachment: bzpost: use treeherder_url() for Try URLs generation

Now that mozautomation has a new treeherder_url(), bzpost should use that,
rather than reimplementing itself. In addition, we want bzpost to link to
Treeherder, rather than TBPL, which this also achieves.

Comment 2

[Ed Morley [:emorley]]

I should add that this is rebased on bug 1085723. Also the newline additions in the file are to fix a few flake8 warnings.

Comment 3

[Ed Morley [:emorley]]

Attachment: bzpost: use treeherder_url() for Try URLs generation

Now with the tests updated too.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8536806 [details] [diff] [review]
bzpost: use treeherder_url() for Try URLs generation

Review of attachment 8536806 [details] [diff] [review]:
-----------------------------------------------------------------

You rock!

Comment 5

[Ed Morley [:emorley]]

Cheers :-)

https://hg.mozilla.org/hgcustom/version-control-tools/rev/3ff16dd37e80

Comment 6

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/dd18f39d4584

Comment 7

[Ed Morley [:emorley]]

Thanks for the fixup :-)

Comment 8

[Ed Morley [:emorley]]

(In reply to Ed Morley (away until 3rd Jan) [:edmorley] from comment #7)
> Thanks for the fixup :-)

Meant to say, I did watch the CI, but it turns out I was watching https://ci.mozilla.org/job/version-control-tools/379/ , which wasn't due to my push, but triggered by timer shortly before it (and Jenkins seems to not trigger another whilst the first is in progress), so I was actually seeing the results of prior to my changes, doh.