Closed Bug 1085719 Opened 7 years ago Closed 7 years ago

bzpost should link to Treeherder instead of TBPL

Categories

(Developer Services :: Mercurial: bzpost, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749] )

Attachments

(1 file, 1 obsolete file)

Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/298]
Depends on: 1085723
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/298] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749] [kanban:engops:https://kanbanize.com/ctrl_board/6/298]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749] [kanban:engops:https://kanbanize.com/ctrl_board/6/298] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/749]
Now that mozautomation has a new treeherder_url(), bzpost should use that,
rather than reimplementing itself. In addition, we want bzpost to link to
Treeherder, rather than TBPL, which this also achieves.
Attachment #8536802 - Flags: review?(gps)
Assignee: nobody → emorley
Status: NEW → ASSIGNED
I should add that this is rebased on bug 1085723. Also the newline additions in the file are to fix a few flake8 warnings.
Now with the tests updated too.
Attachment #8536806 - Flags: review?(gps)
Attachment #8536802 - Attachment is obsolete: true
Attachment #8536802 - Flags: review?(gps)
Comment on attachment 8536806 [details] [diff] [review]
bzpost: use treeherder_url() for Try URLs generation

Review of attachment 8536806 [details] [diff] [review]:
-----------------------------------------------------------------

You rock!
Attachment #8536806 - Flags: review?(gps) → review+
Cheers :-)

https://hg.mozilla.org/hgcustom/version-control-tools/rev/3ff16dd37e80
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Thanks for the fixup :-)
(In reply to Ed Morley (away until 3rd Jan) [:edmorley] from comment #7)
> Thanks for the fixup :-)

Meant to say, I did watch the CI, but it turns out I was watching https://ci.mozilla.org/job/version-control-tools/379/ , which wasn't due to my push, but triggered by timer shortly before it (and Jenkins seems to not trigger another whilst the first is in progress), so I was actually seeing the results of prior to my changes, doh.
You need to log in before you can comment on or make changes to this bug.