108584 - switch over to PRPackedBool where possible

Status: RESOLVED DUPLICATE of bug 695256

(MailNews Core :: Backend, defect)

Description

[(not reading, please use [e-mail] instead)]

switch over to PRPackedBool where possible

alecf writes:

"it's just a PRBool that's only 1 byte large (instead of 4 bytes)
its in prtypes.h I think.  the trick is that if you put it in a struct or a
class (i.e. nsMsgFolder). you should put all the PRPackedBools next to each
other in the declarations"

Comment 1

[Alec Flett]

for a sample of how powerful this can be, check out bug 108597

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: possible candidates

Comment 3

[(not reading, please use [e-mail] instead)]

alecf suggested that we get a bloat log, look for which objects we create a lot 
of, and and then start fixings those first.

these would be good to start with:

./addrbook/src/nsAbCardProperty.h:	PRBool   m_bIsMailList;
./db/msgdb/public/nsMsgHdr.h:    PRBool m_recipientsIsNewsgroup;
./db/msgdb/public/nsMsgThread.h:  PRBool m_cachedValuesInitialized;

Comment 4

[scottputterman]

cc'ing naving who is working on footprint also.

Comment 5

[(not reading, please use [e-mail] instead)]

bienvenu has pointed out that this don't make sense in all cases.

for example, it makes the most sense when you've got a structure with several 
boolean members.

moving to 1.0, this can wait.  we can audit our code later.

Comment 6

[(not reading, please use [e-mail] instead)]

moving to 1.0.1, none of these are 1.0 blockers.

Comment 7

[(not reading, please use [e-mail] instead)]

not needed for nsbeta1, this can wait.

Comment 8

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 9

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"