investigate the cost of sidebar

RESOLVED FIXED in mozilla0.9.9

Status

P1
normal
RESOLVED FIXED
17 years ago
5 years ago

People

(Reporter: cathleennscp, Assigned: samir_bugzilla)

Tracking

Trunk
mozilla0.9.9

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
please provide a patch to remove sidebar to the bug for further analysis.
(Assignee)

Comment 2

17 years ago
Created attachment 56660 [details] [diff] [review]
Patch to remove sidebar (on windows and unix).

Comment 3

17 years ago
Technically <vbox id="sidebar-box" class="chromeclass-extrachrome"/> should 
also be removed.

Comment 4

17 years ago
What does a patch like

Index: sidebarOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/sidebar/resources/sidebarOverlay.js,v
retrieving revision 1.84
diff -u -r1.84 sidebarOverlay.js
--- sidebarOverlay.js	2001/10/27 08:16:56	1.84
+++ sidebarOverlay.js	2001/11/06 04:13:24
@@ -517,6 +517,11 @@
 //////////////////////////////////////////////////////////////
 // Sidebar Init
 //////////////////////////////////////////////////////////////
+
+function sidebar_delayed_overlay_init() {
+  setTimeout("sidebar_overlay_init()", 0);
+}
+
 function sidebar_overlay_init() {
   if (sidebar_is_collapsed() && !gAboutToUncollapse)
     return;
@@ -1075,5 +1080,5 @@
 //////////////////////////////////////////////////////////////
 // Install the load/unload handlers
 //////////////////////////////////////////////////////////////
-addEventListener("load", sidebar_overlay_init, false);
+addEventListener("load", sidebar_delayed_overlay_init, false);
 addEventListener("unload", sidebar_overlay_destruct, false);

get us in terms of perceived speed? (Don't know if it would impact actual 
numbers.)
blake: you may know this, but it saves time spent running the JS compiler at the
call to setTimeout to use the function-calling alternative to the
string-eval'ing one that your example shows: setTimeout(sidebar_overlay_init,
0).  Optional args to the function come after the milliseconds (2nd) arg.  FYI,

/be

Updated

17 years ago
Blocks: 7251
(Assignee)

Updated

17 years ago
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.7 → mozilla0.9.8
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.8 → mozilla0.9.9
(Assignee)

Comment 6

17 years ago
Cost has been investigated.  We are addressing this by implementing a tab
overflow solution so we paint less tab headers.  We found painting the tab
headers were taking a lot of time and affected the combination of new window +
page load time.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.