Closed Bug 1086169 Opened 10 years ago Closed 10 years ago

Intermittent browser_badargs.js,browser_badargs2.js,browser_localfile2.js | installTrigger should have failed - Got , expected exception

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox34 --- unaffected
firefox35 --- unaffected
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: cbook, Assigned: mossop)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Ubuntu VM 12.04 x64 fx-team opt test mochitest-e10s-browser-chrome-3

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=957720&repo=fx-team

18:08:27 INFO - 336 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/xpinstall/browser_localfile2.js | installTrigger should have failed - Got , expected exception
Irving, any idea what might have made this spike today?
Flags: needinfo?(irving)
Summary: Intermittent browser_localfile2.js | installTrigger should have failed - Got , expected exception → Intermittent browser_badargs.js,browser_badargs2.js,browser_localfile2.js | installTrigger should have failed - Got , expected exception
Attached patch patchSplinter Review
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Attachment #8509108 - Flags: review?(bmcbride)
It's not really a spike, these tests only just got turned on in e10s runs
Flags: needinfo?(irving)
Comment on attachment 8509108 [details] [diff] [review]
patch

Review of attachment 8509108 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/test/xpinstall/browser.ini
@@ +71,5 @@
>  [browser_localfile2.js]
>  [browser_localfile3.js]
>  skip-if = e10s # Bug 1082764
>  [browser_localfile4.js]
> +skip-if = true

Bug #?
Attachment #8509108 - Flags: review?(bmcbride) → review+
(In reply to Blair McBride [:Unfocused] from comment #14)
> Comment on attachment 8509108 [details] [diff] [review]
> patch
> 
> Review of attachment 8509108 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/mozapps/extensions/test/xpinstall/browser.ini
> @@ +71,5 @@
> >  [browser_localfile2.js]
> >  [browser_localfile3.js]
> >  skip-if = e10s # Bug 1082764
> >  [browser_localfile4.js]
> > +skip-if = true
> 
> Bug #?

Oops. I'll remove that before landing. For some reason that test fails consistently for me locally but I haven't figured out why yet. It makes testing awkward :(
https://hg.mozilla.org/mozilla-central/rev/1f00a7b26387
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: