Add an abstract class for status bar icons for marionette tests

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gmarty, Assigned: gmarty)

Tracking

unspecified
2.1 S8 (7Nov)
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
Create a class to abstract away the interactions with the status bar icons to easily create and maintain marionette tests.

See apps/system/test/marionette/lib/system.js for a model.
(Assignee)

Updated

4 years ago
Assignee: nobody → gmarty
Blocks: 1087710
Blocks: 1087788
(Assignee)

Comment 2

4 years ago
Created attachment 8511109 [details] [review]
Github PR

Here's the beginning of the testing class. It comes with a set of files performing basic feature tests.
The idea is to add more tests later and more helpers if needed.

Etienne, what do you think of it? Any suggestions on how to improve it?
Attachment #8511109 - Flags: review?(etienne)
Comment on attachment 8511109 [details] [review]
Github PR

This is brilliant. r=me with the few comments on github addressed.

But we should wait for Kevin's go (see github) regarding the timeout extension for the geolocation test before landing.

Do we already have a bug file to "Cover icon prioritization with integration tests"? :)
Flags: needinfo?(kgrandon)
Attachment #8511109 - Flags: review?(etienne) → review+
Nice work. I left some comments on github, but I think we're ok here? Let me know if that's not the case.
Flags: needinfo?(kgrandon)
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S7 (24Oct)
(Assignee)

Comment 5

4 years ago
Thanks Kevin and Etienne for your input, I addressed your comments on an updated PR and replied on Github.
Currently waiting on TBPL before landing.
Target Milestone: 2.1 S7 (24Oct) → 2.1 S8 (7Nov)
(Assignee)

Comment 6

4 years ago
Landed in master as of https://github.com/mozilla-b2g/gaia/commit/8b619f8496adc3e7fafcdd1d7008066d795388c6
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.