Closed Bug 1086209 Opened 10 years ago Closed 10 years ago

[NFC] Remove window parameter for NfcContentHelper API

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S8 (7Nov)

People

(Reporter: dimi, Assigned: dimi)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file, 1 obsolete file)

Rebased patch
21.06 KB, patch
dimi
: review+
Details | Diff | Splinter Review 
After Bug 1058440 landed, NfcContentHelper has a init function and should be called when init.
In current usage, Nfc.js will pass window parameter to NfcContentHelper using init function so API supported by NfcContentHelper will no longer require additional window parameter.

This bug will remove those unnecessary window parameter.
Assignee: nobody → dlee
Attached patch Patch v1 (obsolete) — — Splinter Review 

        Attachment #8514128 -
        Flags: review?(allstars.chh)

        Attachment #8514128 -
        Flags: review?(allstars.chh) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Rebased patch
        — 
          — Splinter Review
      

    


  

        Attachment #8514128 -
        Attachment is obsolete: true

        Attachment #8514192 -
        Flags: review+

    
  
Keywords: checkin-needed
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S8 (7Nov)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/619f33ed9ef0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: